Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the build process for Firebase C++ SDK on Apple platforms (iOS and tvOS) by adopting CMake's native support for these operating systems. By removing custom toolchain files and updating build configurations and documentation, the change simplifies future maintenance and aligns the project with modern CMake practices, making the build setup more robust and easier to understand. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Integration test with FLAKINESS (succeeded after retry)Requested by @AustinBenoit on commit 9fb12a2
Add flaky tests to go/fpl-cpp-flake-tracker |
There was a problem hiding this comment.
Code Review
The pull request refactors the iOS and tvOS build system to leverage native CMake support (version 3.14+), deprecating custom toolchain files. This involves updating documentation, CMakeLists.txt, shell build scripts, and Python build scripts to use CMAKE_SYSTEM_NAME=iOS or CMAKE_SYSTEM_NAME=tvOS and explicitly setting CMAKE_OSX_SYSROOT for simulator builds. A review comment points out that the test_mac_ios_simulator.sh script, after these changes, no longer explicitly sets CMAKE_OSX_SYSROOT=iphonesimulator, which could lead to ambiguity in SDK selection for iOS simulator builds and should be addressed to maintain build consistency.
Description
Cleaning up cmake with the new version that natively supports finding the iOS root directories
Testing
Built ios locally and ran integration tests.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.