Skip to content

Conversation

@dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jan 22, 2026

Adds support for regexFind and regexFindAll expressions in the Pipeline and RealtimePipeline API.

@dlarocque dlarocque requested a review from wu-hui January 22, 2026 16:34
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dlarocque dlarocque marked this pull request as draft January 22, 2026 16:37
@dlarocque
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for regexFind and regexFindAll expressions in the Firestore Pipelines API, along with corresponding test cases and internal evaluation logic. The changes are well-structured, adding new API methods, registering them, implementing their evaluation, and providing comprehensive tests. Overall, the new functionality is a valuable addition.

@dlarocque
Copy link
Contributor Author

/gemini review

@dlarocque dlarocque marked this pull request as ready for review January 23, 2026 17:55
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for regexFind and regexFindAll expressions in the Firestore Pipelines API. The implementation includes new API methods, evaluation logic, and comprehensive unit and instrumented tests. The code is well-structured, with clear separation of concerns, and includes good error handling for invalid regular expressions and unsupported capturing group scenarios. The Javadoc for the new API methods is thorough and provides helpful examples.

…/util/RegexUtils.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant