Skip to content

Conversation

@dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jan 21, 2026

Refactors Firestore README to fix setup inaccuracies I found when setting up my local dev environment and improves the documentation for running integration tests.

  • Corrected google-services.json path: The previous instruction for placing google-services.json at the root dir was incorrect, and caused the tests to fallback to using a dummy config, which caused my tests to fail. After moving the file to firebase-firestore/google-services.json the tests passed for me.
  • Documented hidden CLI flags (-PtargetBackend, -PbackendEdition, -PtargetDatabaseId)
  • Removed IDE-specific Run Configurations, which I couldn't find in Android Studio anywhere. I don't think they exist anymore.
  • Moved prerequisites section to the very of the testing section, instead of being buried below build commands

@dlarocque dlarocque requested review from rlazo and wu-hui January 21, 2026 15:49
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dlarocque
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the clarity and accuracy of the Firestore setup instructions. The refactoring of the README makes it much more organized and easier for developers to follow. Documenting the previously hidden CLI flags is also a very helpful addition. I've identified a couple of minor opportunities for improvement and one important inconsistency regarding the google-services.json file path that should be addressed to avoid confusion.

dlarocque and others added 2 commits January 21, 2026 11:04
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants