[DRAFT] Fireperf AQS changes #7639
Conversation
Based on the behaviour of AQS w/ Fireperf, an AQS session isn't available when (currently) logging gauge metadata. Changes: - Remove the current logging of gauge metadata - will be re-introduced in a future PR. - Switch Gauge collection from `scheduleAtFixedRate` to `scheduleWithFixedDelay`. As [documented](https://stackoverflow.com/a/78405653), this *should* prevent a potentially large amounts of gauge collection if a process is cached, and then restored during a verbose session - which *should* make it work better w/ AQS. - Remove API restricted behaviour which is no longer relevant.
This PR doesn't change the use of session ID to AQS - except in GaugeMetadata. I've added TODOs to identify the missing locations.
- Override PerfSession session id to aqs session id when possible - Add assertion for debug mode to double check if aqs session id available by the time of use
Leverage on `ProcessDetailsProvider` to retrieve process name info
- Update Gauge metrics collection frequency to be independent of Session Change. - Update GaugeMetric logging to log them based on metrics count - Necessary changes in SessionManager (remove app state monitor) There's a non-trivial number of unit test failures in GaugeManager. This PR marks them as Ignore with a TODO.
…6953) - Fixes relevant unit tests - specifically requiring a definite `ApplicationProcessState` - Adds new unit tests for the updated behaviour - Deletes unit tests that *should* be OK to delete.
- This is based on `firebase-sessions/src/main/kotlin/com/google/firebase/sessions/ProcessDetailsProvider.kt` - Usage in `AppStartTrace` and `TransportManager` - Reverts changes in `firebase-sessions/src/main/` to `main`
As part of looking into refactoring `GaugeCounter` I noticed I'd missed this increment.
- Update frequency of Gauge logging to better match the existing implementation. - Update GaugeMetadata logging to only log metadata if it's a verbose session.
This changes the main activity to be on the default process, allowing the more typical FirebaseInitProvider initialization of Firebase. The other processes will still initialize manually
…tter match early initialization in AQS. (#7184) This sets the subscriber in FirebasePerfEarly - allowing AQS to send a session sooner. The removal of `SessionManager.getInstance().initializeGaugeCollection();` seems like the right solution given an AQS will be created ASAP. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…pdate comments. (#7197)
The current dependency was set to HEAD. This switches it back to 3.0.0. This is needed for shipping it in an EAP.
Based on our discussion, updated this PR with the following changes: - Removed excessive logs for legacy sessions. - Changed the logs for sessions list to log only if *all* the sessions were legacy. - Added unit tests to verify the behaviour of verbose and legacy sessions, which keeps legacy sessions as the first *only* if there's no verbose session.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (c8ada3c) and merge commit (77efe47).Test Logs |
4 participants
No description provided.