Skip to content

fix(data-connect): correctly serialize strings with special characters #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(data-connect): correctly serialize strings with special characters #3056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca27c88
Fix: Correctly serialize strings with special characters in DataConnect
google-labs-jules[bot] Jan 17, 2026
3c739c5
Fix: Address PR comments and add more tests
google-labs-jules[bot] Jan 17, 2026
c0328da
Address review feedback.
yuchenshi Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/data-connect/data-connect-api-client-internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,7 @@ export class DataConnectApiClient {
*/
private objectToString(data: unknown): string {
if (typeof data === 'string') {
const escapedString = data
.replace(/\\/g, '\\\\') // Replace \ with \\
.replace(/"/g, '\\"'); // Replace " with \"
return `"${escapedString}"`;
return JSON.stringify(data);
}
if (typeof data === 'number' || typeof data === 'boolean' || data === null) {
return String(data);
Expand Down
57 changes: 57 additions & 0 deletions test/unit/data-connect/data-connect-api-client-internal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,4 +928,61 @@ describe('DataConnectApiClient CRUD helpers', () => {
.to.be.rejectedWith(FirebaseDataConnectError, `${serverErrorString}. ${additionalErrorMessageForBulkImport}`);
});
});

describe('String serialization', () => {
it('should correctly escape special characters in strings during insert', async () => {
const data = {
content: 'Line 1\nLine 2',
};

await apiClient.insert(tableName, data);
const callArgs = executeGraphqlStub.firstCall.args[0];

expect(callArgs).to.include(String.raw`content: "Line 1\nLine 2"`);
});

it('should correctly escape backslash', async () => {
const data = {
content: 'Backslash \\',
};

await apiClient.insert(tableName, data);
const callArgs = executeGraphqlStub.firstCall.args[0];

expect(callArgs).to.include(String.raw`content: "Backslash \\"`);
});

it('should correctly escape double quotes', async () => {
const data = {
content: 'Quote "test"',
};

await apiClient.insert(tableName, data);
const callArgs = executeGraphqlStub.firstCall.args[0];

expect(callArgs).to.include(String.raw`content: "Quote \"test\""`);
});

it('should correctly escape tab character', async () => {
const data = {
content: 'Tab\tCharacter',
};

await apiClient.insert(tableName, data);
const callArgs = executeGraphqlStub.firstCall.args[0];

expect(callArgs).to.include(String.raw`content: "Tab\tCharacter"`);
});

it('should correctly handle emojis', async () => {
const data = {
content: 'Emoji 😊',
};

await apiClient.insert(tableName, data);
const callArgs = executeGraphqlStub.firstCall.args[0];

expect(callArgs).to.include('content: "Emoji 😊"');
});
});
});
Loading