-
Notifications
You must be signed in to change notification settings - Fork 412
feat(rc): Support Rollout, Personalization, and Experiment values #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashish-kothari
wants to merge
5
commits into
main
Choose a base branch
from
kotharas/rc-managed-values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
881b4b9
Support Rollout, Personalization, and Experiment values in Remote Con…
google-labs-jules[bot] 1df9cc3
Address issue with server templates evaluating unsupported values
ashish-kothari 85c5cd1
Generate apidocs
ashish-kothari 802ab0d
Add assertions for new Remote Config value types in createTemplateFro…
google-labs-jules[bot] dea5828
Generate apidocs again
ashish-kothari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -354,12 +354,73 @@ export interface InAppDefaultValue { | |
| useInAppDefault: boolean; | ||
| } | ||
|
|
||
| /** | ||
| * Represents a Rollout value. | ||
| */ | ||
| export interface RolloutValue { | ||
| rolloutId: string; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add the documentation to all the new fields. See |
||
| value: string; | ||
| percent: number; // Numeric value between 1-100 | ||
| } | ||
|
|
||
| /** | ||
| * Represents a Personalization value. | ||
| */ | ||
| export interface PersonalizationValue { | ||
| personalizationId: string; | ||
| } | ||
|
|
||
| /** | ||
| * Represents a specific variant value within an Experiment. | ||
| */ | ||
| export interface ExperimentVariantExplicitValue { | ||
| variantId: string; | ||
| value: string; | ||
| noChange?: never; | ||
| } | ||
|
|
||
| /** | ||
| * Represents a no-change variant value within an Experiment. | ||
| */ | ||
| export interface ExperimentVariantNoChange { | ||
| variantId: string; | ||
| value?: never; | ||
| noChange: true; | ||
| } | ||
|
|
||
| export type ExperimentVariantValue = ExperimentVariantExplicitValue | ExperimentVariantNoChange; | ||
|
|
||
| /** | ||
| * Represents an Experiment value. | ||
| */ | ||
| export interface ExperimentValue { | ||
| experimentId: string; | ||
| variantValue: ExperimentVariantValue[]; | ||
| } | ||
|
|
||
| export interface RolloutParameterValue { | ||
| rolloutValue: RolloutValue; | ||
| } | ||
|
|
||
| export interface PersonalizationParameterValue { | ||
| personalizationValue: PersonalizationValue; | ||
| } | ||
|
|
||
| export interface ExperimentParameterValue { | ||
| experimentValue: ExperimentValue; | ||
| } | ||
|
|
||
| /** | ||
| * Type representing a Remote Config parameter value. | ||
| * A `RemoteConfigParameterValue` could be either an `ExplicitParameterValue` or | ||
| * an `InAppDefaultValue`. | ||
| */ | ||
| export type RemoteConfigParameterValue = ExplicitParameterValue | InAppDefaultValue; | ||
| export type RemoteConfigParameterValue = | ||
| | ExplicitParameterValue | ||
| | InAppDefaultValue | ||
| | RolloutParameterValue | ||
| | PersonalizationParameterValue | ||
| | ExperimentParameterValue; | ||
ashish-kothari marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * Interface representing a Remote Config parameter. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the missing documentation here and below