docs: getting started on android FirebaseUI v10#2309
docs: getting started on android FirebaseUI v10#2309russellwheatley wants to merge 1 commit intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new getting started guide for FirebaseUI Auth v10 on Android. The guide focuses on the new Compose-based authentication library, detailing its integration, configuration, and customization capabilities. It aims to provide developers with a clear path to implement modern authentication flows using Jetpack Compose, while also offering guidance for migrating from previous versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces a new GETTING_STARTED.md documentation file for FirebaseUI Auth for Android, detailing its features, setup, provider configuration, sign-in/out flows, customization, and migration guidance. A review comment suggests improving the dependency declarations in this new guide by replacing <latest-version> placeholders with specific, known-working versions to prevent potential build issues and enhance user experience.
| implementation(platform("com.google.firebase:firebase-bom:<latest-version>")) | ||
| implementation("com.google.firebase:firebase-auth") | ||
|
|
||
| implementation(platform("androidx.compose:compose-bom:<latest-version>")) | ||
| implementation("androidx.compose.material3:material3") | ||
|
|
||
| // Required only if Facebook Login support is needed | ||
| implementation("com.facebook.android:facebook-login:<latest-version>") |
There was a problem hiding this comment.
For a getting started guide, using specific, known-working versions for dependencies is generally more helpful than <latest-version> placeholders. This prevents potential build issues for users who might not know where to find the most recent stable versions. Consider using the specific versions listed in auth/README.md or adding a note on how to find the latest stable versions for these BOMs and libraries.
| implementation(platform("com.google.firebase:firebase-bom:<latest-version>")) | |
| implementation("com.google.firebase:firebase-auth") | |
| implementation(platform("androidx.compose:compose-bom:<latest-version>")) | |
| implementation("androidx.compose.material3:material3") | |
| // Required only if Facebook Login support is needed | |
| implementation("com.facebook.android:facebook-login:<latest-version>") | |
| implementation(platform("com.google.firebase:firebase-bom:32.7.0")) | |
| implementation("com.google.firebase:firebase-auth") | |
| implementation(platform("androidx.compose:compose-bom:2024.01.00")) | |
| implementation("androidx.compose.material3:material3") | |
| // Required only if Facebook Login support is needed | |
| implementation("com.facebook.android:facebook-login:16.3.0") |
Uh oh!
There was an error while loading. Please reload this page.