feat(upstream-proxy): add HTTP Basic and NTLM auth methods#1551
Open
Andreybest wants to merge 4 commits into
Open
feat(upstream-proxy): add HTTP Basic and NTLM auth methods#1551Andreybest wants to merge 4 commits into
Andreybest wants to merge 4 commits into
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
==========================================
- Coverage 90.65% 90.43% -0.22%
==========================================
Files 69 70 +1
Lines 5690 5906 +216
Branches 985 1034 +49
==========================================
+ Hits 5158 5341 +183
- Misses 514 546 +32
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added HTTP Basic and NTLM authentication methods for upstream proxy.
HTTP Basic was already available by providing
username:passwordin url of proxy, now it is also can be passed inauthparam inproxy.config.json.NTLM was added, tested on local docker squid + samba proxy. But not sure if it is the sme as the one on windows production proxy environments. Would appreciate testing/suggestions on that :)
Negotiate was omitted because support for it has already been merged into the
https-proxy-agentpackage upstream, but a new release containing it hasn't been published yet.Related Issue
Resolves #1541 (partially)
Checklist
General
Documentation
Configuration
config.schema.json) was modified:npm run generate-config-types)npm run gen-schema-doc)Tests
npm test)npm run lintandnpm run format:check)npm run check-types)