Skip to content

feat(upstream-proxy): add HTTP Basic and NTLM auth methods#1551

Open
Andreybest wants to merge 4 commits into
finos:mainfrom
Andreybest:1541-http-basic-ntlm
Open

feat(upstream-proxy): add HTTP Basic and NTLM auth methods#1551
Andreybest wants to merge 4 commits into
finos:mainfrom
Andreybest:1541-http-basic-ntlm

Conversation

@Andreybest
Copy link
Copy Markdown
Contributor

Description

Added HTTP Basic and NTLM authentication methods for upstream proxy.

HTTP Basic was already available by providing username:password in url of proxy, now it is also can be passed in auth param in proxy.config.json.

NTLM was added, tested on local docker squid + samba proxy. But not sure if it is the sme as the one on windows production proxy environments. Would appreciate testing/suggestions on that :)

Negotiate was omitted because support for it has already been merged into the https-proxy-agent package upstream, but a new release containing it hasn't been published yet.

Related Issue

Resolves #1541 (partially)

Checklist

General

Documentation

  • Documentation has been added/updated for any new features

Configuration

  • If configuration schema (config.schema.json) was modified:
    • TypeScript types regenerated (npm run generate-config-types)
    • Schema reference docs regenerated (npm run gen-schema-doc)

Tests

  • Tests have been added/updated for new functionality
  • Unit tests pass (npm test)
  • Linting and formatting pass (npm run lint and npm run format:check)
  • Type checks pass (npm run check-types)

@Andreybest Andreybest requested a review from a team as a code owner May 29, 2026 17:50
@netlify
Copy link
Copy Markdown

netlify Bot commented May 29, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit e1b4df0
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a19d6d2958b88000864d0a8

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 85.13514% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.43%. Comparing base (ffd6937) to head (e1b4df0).

Files with missing lines Patch % Lines
src/proxy/upstream/ntlm-proxy-agent.ts 83.05% 29 Missing and 1 partial ⚠️
src/proxy/routes/index.ts 93.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
- Coverage   90.65%   90.43%   -0.22%     
==========================================
  Files          69       70       +1     
  Lines        5690     5906     +216     
  Branches      985     1034      +49     
==========================================
+ Hits         5158     5341     +183     
- Misses        514      546      +32     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add direct authentication support for the upstream proxy agent (HTTP Basic, NTLM, Negotiate)

1 participant