feat: expose service module through package exports (#1539)

[rajeevr-g]

Description

Exposes the service module through package exports and updates configuration exports to support service module accessibility.

General changes:

• Added package exports entry for the service module
• Updated src/config/index.ts to expose the required configuration exports
• Ensured service module accessibility through package-level exports
• Verified project build and TypeScript publish build complete successfully
• Validated linting, formatting, and type checks pass successfully

Related Issue

Resolves #1539

Checklist

General

• I have read the CONTRIBUTING.md guidelines
• Commit messages follow Conventional Commits format
• I have a FINOS CLA on file

Documentation

• Documentation has been added/updated for any new features

Configuration

• If configuration schema (config.schema.json) was modified:

  • TypeScript types regenerated (npm run generate-config-types)
  • Schema reference docs regenerated (npm run gen-schema-doc)

Tests

• Unit tests pass (npm test)
• Linting and formatting pass (npm run lint and npm run format:check)
• Type checks pass (npm run check-types)

[netlify]

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name	Link
🔨 Latest commit	02300d3
🔍 Latest deploy log	https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a1de53cdc0ecd00099b0309

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rajeevr-g / name: rajeevr-g (002903d)

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.62%. Comparing base (ffd6937) to head (02300d3).

Files with missing lines	Patch %	Lines
src/config/index.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
- Coverage   90.65%   90.62%   -0.03%     
==========================================
  Files          69       69              
  Lines        5690     5694       +4     
  Branches      985      985              
==========================================
+ Hits         5158     5160       +2     
- Misses        514      516       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[re-vlad]

Hi @andypols @kriswest @jescalada, @Andreybest, dear @git-proxy-maintainers,

Could you please prioritize a review of this PR #1542 “feat: expose service module through package exports (#1539)”?

This change is critical for us because we need the service module to be available through package exports in order to validate our migration path to the 2.0.0 release.

If anything needs adjustment from our side, we can respond quickly.

Thank you for your help and for maintaining the project,
Vlad (re-vlad)

[jescalada]

LGTM, thanks for the contribution @rajeevr-g! It'll need an extra review, however, as I fixed merge conflicts in the latest commit 👍🏼

[rajeevr-g]

Hi @andypols @kriswest, dear @git-proxy-maintainers,

Could you please help prioritize the review of PR #1542:
#1542

This change is important for us because we need the service module to be exposed through package exports to validate our migration path for the 2.0.0 release and ensure our integration works successfully.

If any adjustments or updates are needed from our side, we’ll be happy to address them promptly.

Thank you for your time and for maintaining the project.

Best regards,
Rajeev

[kriswest]

I don't have a problem with this being exposed, however, it could be handled in a way that's more consistent with the exposure of other parts of the config, via a get* function. I don't like the fact that this part of the config sets defaults differently and that we can't set many of these settings from a config file (with the exception of GIT_PROXY_COOKIE_SECRET which can be set in config and overridden by an ENV var).

Personally, I think this should be refactored and made consistent with the rest of the config handling and worry that directly exporting it will lock in the current, inconsistent design.

@jescalada could you take another look? Is there an advantage to us only setting some of these thrings through env vars or using the defaults? Why not have config variables and defaults (set via the same approach as all others) for some of these critical settings?

[kriswest]

To avoid locking in the technical debt relating to env.ts / serverConfig, it should not be exported but a get function added to allow access to those settings. Even better would be a quick refactor to allow those settings to come from config in addition to env vars and to move their defaults into proxy.config.json.

GIT_PROXY_COOKIE_SECRET is the one variable that is currently settable from both config file and environment variable and can be used as an example:

see:

git-proxy/src/config/index.ts

Lines 187 to 190 in ffd6937

	cookieSecret:
	serverConfig.GIT_PROXY_COOKIE_SECRET ||
	userSettings.cookieSecret ||
	defaultConfig.cookieSecret,

and:

git-proxy/src/config/index.ts

Lines 301 to 309 in ffd6937

	export const getCookieSecret = (): string => {
	const config = loadFullConfiguration();
	if (!config.cookieSecret) {
	throw new Error('cookieSecret is not set!');
	}
	return config.cookieSecret;
	};

I'm fine with the rest of this PR!

[kriswest]

I've created issue #1553 to describe whats needed to fix the server config env variables properly.

[kriswest]

LGTM, as far as it goes.