feat(event-handlers): introduce event handler system for GitProxy lifecycle events by Andreybest · Pull Request #1519 · finos/git-proxy

Andreybest · 2026-05-05T23:11:41Z

Implements #1449.

Introduces a lightweight, async, observer-only event system so external integrations (notifications, audit feeds) can react to push/pull lifecycle events without coupling to chain internals.

Event hooks can be added the same way as the plugins in config.proxy.json

Supports 2 operations: pull and push
With 5 phases:

started
completed
error
permissionDenied
pendingReview

This is not well documented, and not sure where to add info on that, would appreciate suggestions on that matter :)

…ecycle events

netlify · 2026-05-05T23:11:46Z

✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name	Link
🔨 Latest commit	`5466dbd`
🔍 Latest deploy log	https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a0e6a424c8d5c0009c23a96
😎 Deploy Preview	https://deploy-preview-1519.git-proxy.preview.finos.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2026-05-05T23:15:36Z

Codecov Report

❌ Patch coverage is 94.70199% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (82031e9) to head (5466dbd).

Files with missing lines	Patch %	Lines
src/eventHandlers/loader.ts	91.17%	6 Missing ⚠️
src/proxy/chain.ts	75.00%	5 Missing ⚠️
src/eventHandlers/dispatcher.ts	97.53%	1 Missing and 1 partial ⚠️
src/eventHandlers/index.ts	0.00%	2 Missing ⚠️
src/config/index.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
+ Coverage   90.10%   90.33%   +0.22%     
==========================================
  Files          69       75       +6     
  Lines        5657     5957     +300     
  Branches      990     1053      +63     
==========================================
+ Hits         5097     5381     +284     
- Misses        541      556      +15     
- Partials       19       20       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

andypols · 2026-05-12T13:59:59Z

@Andreybest Could I vote for an additional phase?

We have several custom actions that run when a push is first received and the proxy blocks it for review. This state is not really permissionDenied or error; it is closer to pendingReview.

We also have custom actions that would work really well as plugin events. For example, we:

run an AI-based security audit of the changes
create an AI summary of the changes to help the reviewer
notify reviewers when there is a push to review

It would be great if plugins could also add data that can be rendered in the UI.

This would be a hugely helpful change, as it would allow us to separate our custom code from the base git-proxy. Keeping the two in sync is painful at the moment.

Andreybest · 2026-05-13T18:06:30Z

Hey @andypols ! Thanks for the suggestion, this seems like a good use cases for events. Will try to add mechanisms that would be able to support your use cases :)
Will ping you on that later.

re-vlad

Just a wish: while the code is well-documented, there's no external docs (README, docs, etc.) explaining how to use the event system. This should be added.

re-vlad · 2026-05-14T11:03:54Z

  "contactEmail": "",
  "csrfProtection": true,
  "plugins": [],
+  "eventHandlers": [],


The config schema shows the eventHandlers array, but there are no examples of how to configure event handlers in proxy.config.json. Consider to document example

Added documentation for that in architecture.md. Thanks!

re-vlad · 2026-05-14T11:51:17Z

+  if (!action.user && !action.userEmail) {
+    return undefined;
+  }
+  return { username: action.user, email: action.userEmail };


EventDetails.user and repository must be immutable copies (using String()) of Action fields — not references. Otherwise, async handlers may see stale or modified data if Action is mutated later in the chain. This rather critical I believe, but easy to fix:

return { username = action.user ? String(action.user) : undefined; email = action.userEmail ? String(action.userEmail) : undefined; }```.

Both values are strings, and strings are copied by value, not by reference, thus why this is unnecessary.

I think Vlad's point here is that there is no object-level protection, in other words the fields can be overwritten unless we enforced the contract via something like Object.freeze(details.user) after defining details below.

For example, the following event handler would affect any subsequent handlers that use the EventDetails:

export default new EventHandlerPlugin(() => { const redact = (details: EventDetails) => { if (details.user) { details.user.email = '<redacted>'; } sendTo3rdPartyApp(details); }; registry.onPush().onCompleted(redact); });

re-vlad · 2026-05-14T11:56:38Z

+} from './types';
+
+const buildRepositoryContext = (action: Action): RepositoryContext => ({
+  url: action.url,


The same problem like line 38, don't return references, return values instead:

name: action.repoName? String(action.repoName) : undefined, url: String(action.url),

Responded on comment above

Andreybest · 2026-05-21T02:22:29Z

@Andreybest Could I vote for an additional phase?

We have several custom actions that run when a push is first received and the proxy blocks it for review. This state is not really permissionDenied or error; it is closer to pendingReview.

We also have custom actions that would work really well as plugin events. For example, we:

run an AI-based security audit of the changes

create an AI summary of the changes to help the reviewer

notify reviewers when there is a push to review

It would be great if plugins could also add data that can be rendered in the UI.

This would be a hugely helpful change, as it would allow us to separate our custom code from the base git-proxy. Keeping the two in sync is painful at the moment.

Hey @andypols! Added a new phase - pendingReview. Which indicates that the Action is blocked and not autoApproved and not autoRejected

On "add data that can be rendered in the UI", not sure if this should be the part of this PR, since the current architecture of event hooks is to inform a plugin that something happened in a manner of "fire-and-forget". And as I understand this will also require changes to database schema itself.

Please let me know if I understood what you have meant. :)

andypols · 2026-05-21T21:10:45Z

Hey @andypols! Added a new phase - pendingReview. Which indicates that the Action is blocked and not autoApproved and not autoRejected

On "add data that can be rendered in the UI", not sure if this should be the part of this PR, since the current architecture of event hooks is to inform a plugin that something happened in a manner of "fire-and-forget". And as I understand this will also require changes to database schema itself.

Please let me know if I understood what you have meant. :)

@Andreybest Thats sounds perfect. It makes sense that the UI is in a different PR, although not sure about the need for a scheme change (we have this and did not need one)

jescalada

@Andreybest Thanks for the contribution! It's looking great so far.

It'd be great to have a simple doc on how to configure a preexisting handler (such as the consoleLogger), and how to develop a new one. A short step-by-step guide will make it easier for everyone to adopt.

It'd be fantastic to have an extra builtin handler for sending emails as mentioned in #1121, although we could add it in a separate PR.

jescalada · 2026-05-28T01:45:03Z

This is a great example file to use for the Event Handler documentation 🙂

jescalada · 2026-05-28T01:48:55Z

+ * operations. For blocking/policy logic, write a chain plugin instead.
+ *
+ * Handlers run asynchronously, fire-and-forget. Errors thrown by a handler
+ * are caught and logged but never propagate to the git response.


These details would be best explained in a separate document - things like when to choose an event handler over a plugin as they're superficially similar 👍🏼

jescalada · 2026-05-28T02:05:03Z

  errorMessage?: string | null;
  blocked: boolean = false;
  blockedMessage?: string | null;
+  permissionDenied: boolean = false;


I understand permissionDenied is set exclusively when checkUserPushPermission fails. I wonder if there's a more elegant solution - perhaps storing the name of the step where the Action failed. We could also infer this from the lastStep so we wouldn't need the extra field.

I see the value of handling the specific case of permissionDenied. I'm just wondering if we could prevent future bloat from happening as people try to add event handling to other, arbitrary push actions.

OTOH, I'd say it's okay to keep it if it makes the event handler implementation more obvious.

jescalada · 2026-05-28T02:21:16Z

+      else if (phase === 'completed') builder.onCompleted(log);
+      else if (phase === 'pendingReview') builder.onPendingReview(log);
+      else if (phase === 'error') builder.onError(log);
+      else if (phase === 'permissionDenied') builder.onPermissionDenied(log);


Might want to have an else to handle things if someone added an additional ActionPhase but forgot to update the switch here.

jescalada · 2026-05-28T02:33:03Z

+  if (!action.user && !action.userEmail) {
+    return undefined;
+  }
+  return { username: action.user, email: action.userEmail };


I think Vlad's point here is that there is no object-level protection, in other words the fields can be overwritten unless we enforced the contract via something like Object.freeze(details.user) after defining details below.

For example, the following event handler would affect any subsequent handlers that use the EventDetails:

export default new EventHandlerPlugin(() => { const redact = (details: EventDetails) => { if (details.user) { details.user.email = '<redacted>'; } sendTo3rdPartyApp(details); }; registry.onPush().onCompleted(redact); });

feat(event-handlers): introduce event handler system for GitProxy lif…

e53fccb

…ecycle events

Andreybest requested a review from a team as a code owner May 5, 2026 23:11

Andreybest requested a review from grovesy May 5, 2026 23:11

re-vlad reviewed May 14, 2026

View reviewed changes

re-vlad suggested changes May 14, 2026

View reviewed changes

Andreybest added 3 commits May 21, 2026 04:01

Merge branch 'main' into 1449-event-hooks

6b59e45

feat(events): add pendingReview action

3be5e89

feat(events): add documentation on new parameter in config

5466dbd

Andreybest requested a review from re-vlad May 21, 2026 02:17

jescalada requested changes May 28, 2026

View reviewed changes

Conversation

Andreybest commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Uh oh!

codecov Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

andypols commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andreybest commented May 13, 2026

Uh oh!

re-vlad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

re-vlad May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andreybest commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andypols commented May 21, 2026

Uh oh!

jescalada left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Andreybest commented May 5, 2026 •

edited

Loading

netlify Bot commented May 5, 2026 •

edited

Loading

codecov Bot commented May 5, 2026 •

edited

Loading

andypols commented May 12, 2026 •

edited

Loading

re-vlad May 14, 2026 •

edited

Loading

Andreybest commented May 21, 2026 •

edited

Loading