Skip to content

Code Quality: Fixed duplicate thumbnail loading calls for cached files#18075

Merged
yair100 merged 1 commit intofiles-community:mainfrom
workbysaran:sg/fix-thumbnail-duplicate-loading-calls
Feb 2, 2026
Merged

Code Quality: Fixed duplicate thumbnail loading calls for cached files#18075
yair100 merged 1 commit intofiles-community:mainfrom
workbysaran:sg/fix-thumbnail-duplicate-loading-calls

Conversation

@workbysaran
Copy link
Copy Markdown
Contributor

Resolved / Related Issues
Fixed unnecessary duplicate thumbnail loading calls for files that already have cached thumbnails.

Steps used to test these changes

  1. Add logs in 'LoadThumbnailAsync' in 'Files.App/ViewModels/ShellViewModel.cs' to track the FileThumbnailHelper calls.
  2. Navigate to any folder with files
  3. Press F5 to refresh
  4. Check logs - should not see duplicate cache calls for same file with the same options

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Feb 2, 2026
@yair100 yair100 changed the title Fix: Duplicate thumbnail loading calls for cached files Code Quality: Fixed duplicate thumbnail loading calls for cached files Feb 2, 2026
@yair100 yair100 merged commit 0581c77 into files-community:main Feb 2, 2026
11 of 12 checks passed
@yair100
Copy link
Copy Markdown
Member

yair100 commented Feb 2, 2026

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants