Merged
Conversation
Fix whitespace Shorten long lines Use print() function Add doc strings Replace single-letter variable names Define main() function Add TODOs for more changes
Order of imports
Since "b" is now "idx_rigt", adjust "b_out" to "out_rigt". Since "i" is now "idx_curr", adjust "last" to "out_curr"
Lowercase variable names for non-constant variables Replace "if len(...) == 0", "if a == False" or "if a == None"
the flush=True argument to print() was only added with py3.3
Collaborator
Author
|
Feel free to criticize, otherwise I will merge this in a few days |
Contributor
|
@christian-intra2net , go for it. But the tests are failing because they are now picking a different shared library? |
Member
|
LGTM for merge as for wrong library, there's unfinished PR: #4 it was never finished |
Contributor
|
Well, PR#4 (I just saw it) is really "hand hurts, cut hand". Perhaps this can be fixed using {,DY}LD_LIBRARY_PATH... so that the file we are testing can find and use the local libmagic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python source code did not comply with python coding standards. Ran the pep8 and pylint static code checkers on all python source files (except threadpool and progressbar which have nothing to do with file(1) functionality). Fixed most of the regressions reported. Mainly:
This should simplify moving to python3 (py2 support ends 2020)