Skip to content

AiMBA: hide dialog after registration success #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quyettvq merged 2 commits into from
Jan 12, 2026
Merged

AiMBA: hide dialog after registration success #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9e2f7
AiMBA: refactor
vanquyettran Jan 9, 2026
74ad131
AiMBA: hide dialog after registration success
quyettvq Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aimba/registration/Registration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {PromoCountdown} from './PromoCountdown';
import {RegistrationForm} from './RegistrationForm';

export let Registration = ({
setDialog,
onRegistrationFormSubmit,
contents: {
registration: {backgroundImage}
Expand Down Expand Up @@ -63,7 +64,7 @@ export let Registration = ({
<div class="description">Ưu đãi có hạn, đăng ký ngay để <com-word>không bỏ lỡ</com-word></div>
<PromoCountdown />
</div>
<RegistrationForm onSubmit={onRegistrationFormSubmit} />
<RegistrationForm onSubmit={onRegistrationFormSubmit} setDialog={setDialog} />
</div>
</div>
</section>
Expand Down
7 changes: 5 additions & 2 deletions src/aimba/registration/RegistrationForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import './RegistrationForm.less';
import {useState} from 'fiddlehead';
import {fbqEmit} from '../tracking';

export let RegistrationForm = ({onSubmit}) => {
export let RegistrationForm = ({onSubmit, setDialog}) => {
let [feedback, setFeedback] = useState(null);

let handleSubmit = (event) => {
Expand All @@ -14,10 +14,13 @@ export let RegistrationForm = ({onSubmit}) => {
setFeedback(feedback);
if (feedback.type === 'success') {
form.reset();
fbqEmit('track', 'Lead');
setTimeout(() => {
setDialog(null);
}, 2000);
}
};
onSubmit({formData, onFeedback});
fbqEmit('track', 'Lead');
};

let handleChange = () => {
Expand Down
19 changes: 6 additions & 13 deletions src/aimba/slider/Slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,13 @@ export let Slider = ({
infinite = false,
children = renderContent
}) => {
let buffer = 2;
let slideAreas = infinite ? ['head', 'body', 'tail'] : ['body'];

let scrollViewRef = useRef(null);
let scrollingEndDebounceRef = useRef(null);
let [scrollable, setScrollable] = useState(false);
let [scrolling, setScrolling] = useState(false);
let [paused, setPaused] = useState(false);
let [slideStates, setSlideStates] = useState(() => {
let states = {};
for (let area of slideAreas) {
Expand All @@ -25,18 +30,6 @@ export let Slider = ({
return states;
});

let scrollViewRef = useRef(null);

let [scrollable, setScrollable] = useState(false);

let [scrolling, setScrolling] = useState(false);

let [paused, setPaused] = useState(false);

let scrollingEndDebounceRef = useRef(null);

let buffer = 2;

let getSlideMargin = () => {
let scrollView = scrollViewRef.current;
if (scrollView == null) {
Expand Down
Loading