Skip to content

Please consider the following formatting changes to #13117 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgrosa merged 1 commit into from
Sep 24, 2025
Merged

Please consider the following formatting changes to #13117 #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PWGHF/TableProducer/mcPidTof.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,10 +465,10 @@
Produces<o2::aod::TOFEvTime> tableEvTime;
Produces<o2::aod::EvTimeTOFOnly> tableEvTimeTOFOnly;
Produces<o2::aod::pidEvTimeFlags> tableFlags;
static constexpr bool removeTOFEvTimeBias = true; // Flag to subtract the Ev. Time bias for low multiplicity events with TOF

Check failure on line 468 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static constexpr float diamond = 6.0; // Collision diamond used in the estimation of the TOF event time

Check failure on line 469 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static constexpr float errDiamond = diamond * 33.356409f;

Check failure on line 470 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static constexpr float weightDiamond = 1.f / (errDiamond * errDiamond);

Check failure on line 471 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".

bool enableTableTOFEvTime = false;
bool enableTableEvTimeTOFOnly = false;
Expand Down Expand Up @@ -719,10 +719,10 @@

// Part 3 Nsigma computation

static constexpr int idxPi = 2;

Check failure on line 722 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static constexpr int idxKa = 3;

Check failure on line 723 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static constexpr int idxPr = 4;

Check failure on line 724 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
static constexpr int idxDe = 5;

Check failure on line 725 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".

/// Task to produce the response table
struct mcPidTof {
Expand Down Expand Up @@ -935,7 +935,7 @@
template <typename T>
T applyMcRecalib(int pidId, T trackPt, T nSigma)
{
if (nSigma < -998) {

Check failure on line 938 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return nSigma;
}

Expand Down Expand Up @@ -968,7 +968,7 @@
aod::BCsWithTimestamps const& bcs,
aod::McParticles const&)
{
constexpr auto responsePi = ResponseImplementation<PID::Pion>();

Check failure on line 971 in PWGHF/TableProducer/mcPidTof.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/constexpr-constant] 

Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".
constexpr auto responseKa = ResponseImplementation<PID::Kaon>();
constexpr auto responsePr = ResponseImplementation<PID::Proton>();
constexpr auto responseDe = ResponseImplementation<PID::Deuteron>();
Expand Down Expand Up @@ -1042,7 +1042,7 @@
nSigma = responseDe.GetSeparation(mRespParamsV3, trk);
if (enableMcRecalib && trk.has_mcParticle()) {
if (std::abs(trk.mcParticle().pdgCode()) == o2::constants::physics::kDeuteron) { // we rescale only true signal
nSigma = applyMcRecalib(idxPr, trk.pt(), nSigma); // FIXME: currently postcalibrations for protons applied to deuterons, to be checked
nSigma = applyMcRecalib(idxPr, trk.pt(), nSigma); // FIXME: currently postcalibrations for protons applied to deuterons, to be checked
}
}
aod::pidutils::packInTable<aod::pidtof_tiny::binning>(nSigma, tablePIDDe);
Expand Down Expand Up @@ -1097,7 +1097,7 @@
nSigma = responseDe.GetSeparation(mRespParamsV3, trk, resolution);
if (enableMcRecalib && trk.has_mcParticle()) {
if (std::abs(trk.mcParticle().pdgCode()) == o2::constants::physics::kDeuteron) { // we rescale only true signal
nSigma = applyMcRecalib(idxPr, trk.pt(), nSigma); // FIXME: currently postcalibrations for protons applied to deuterons, to be checked
nSigma = applyMcRecalib(idxPr, trk.pt(), nSigma); // FIXME: currently postcalibrations for protons applied to deuterons, to be checked
}
}
tablePIDFullDe(resolution, nSigma);
Expand Down
Loading