fix: create blib/arch in generated Makefile for -Mblib compatibility#477
Closed
fix: create blib/arch in generated Makefile for -Mblib compatibility#477
Conversation
The generated Makefile pure_all target only created blib/lib/ but not blib/arch/. The blib.pm pragma requires both directories to exist (-d blib && -d blib/lib && -d blib/arch), so use blib and -Mblib would die with Cannot find blib even in ... This caused CPAN module test suites (e.g. HTTP::Thin) to fail when they use open3 with -Mblib to verify modules load cleanly. Add mkdir -p blib/arch to the pure_all target so the directory always exists alongside blib/lib. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Owner
Author
|
Superseded by a combined PR with additional Hash::MultiValue fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pure_alltarget only createdblib/lib/but notblib/arch/blib.pmpragma requires all three directories (blib/,blib/lib/,blib/arch/) to existblib/arch/,use blib/-Mblibdies withCannot find blib even in ...t/00-compile.t) to fail when they useopen3($^X, '-Mblib', ...)to verify modules load cleanlyFix
Add
mkdir -p blib/archto thepure_alltarget in the generated Makefile so the directory always exists alongsideblib/lib.Test plan
makepasses (all unit tests green)./jcpan -t HTTP::Thinnow passes (t/00-compile.t .. ok)Generated with Devin