Fix header forwarding in receiveMessagesPoll for localstack#4
Merged
Conversation
receiveMessagesPoll used a raw fetch without x-localstack-endpoint/x-localstack-region headers, so the backend fell back to the default region and returned 404 "Queue not found" for queues created in other regions. Export getConfigHeaders from api-client and apply it to the polling fetch.
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the way API requests are made to the SQS backend by ensuring that configuration headers are consistently included. The main change is the use of a shared
getConfigHeadersfunction to add custom headers to SQS API requests, improving maintainability and consistency.API request improvements:
receiveMessagesPollinsqs.tsto include custom configuration headers in fetch requests by using the newgetConfigHeadersfunction.sqs.tsto bring ingetConfigHeadersfromapi-client.ts.Code sharing and export:
getConfigHeadersinapi-client.tsto be exported, making it available for use in other modules.