Skip to content

Quality: Resource leak: XDMFFile not closed in MeshFromXDMF.__init__ #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Quality: Resource leak: XDMFFile not closed in MeshFromXDMF.__init__ #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions src/festim/mesh/mesh_from_xdmf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ def __init__(
self.surface_meshtags_name = surface_meshtags_name
self.volume_meshtags_name = volume_meshtags_name

volumes_file = XDMFFile(MPI.COMM_WORLD, self.volume_file, "r")
mesh = volumes_file.read_mesh(name=f"{self.mesh_name}")
with XDMFFile(MPI.COMM_WORLD, self.volume_file, "r") as volumes_file:
mesh = volumes_file.read_mesh(name=f"{self.mesh_name}")

super().__init__(mesh=mesh)

Expand All @@ -53,10 +53,10 @@ def define_surface_meshtags(self):
Returns:
dolfinx.MeshTags: the facet meshtags
"""
facets_file = XDMFFile(MPI.COMM_WORLD, self.facet_file, "r")
facet_meshtags = facets_file.read_meshtags(
self.mesh, name=f"{self.surface_meshtags_name}"
)
with XDMFFile(MPI.COMM_WORLD, self.facet_file, "r") as facets_file:
facet_meshtags = facets_file.read_meshtags(
self.mesh, name=f"{self.surface_meshtags_name}"
)

return facet_meshtags

Expand All @@ -66,10 +66,9 @@ def define_volume_meshtags(self):
Returns:
dolfinx.MeshTags: the volume meshtags
"""
volume_file = XDMFFile(MPI.COMM_WORLD, self.volume_file, "r")

volume_meshtags = volume_file.read_meshtags(
self.mesh, name=f"{self.volume_meshtags_name}"
)
with XDMFFile(MPI.COMM_WORLD, self.volume_file, "r") as volume_file:
volume_meshtags = volume_file.read_meshtags(
self.mesh, name=f"{self.volume_meshtags_name}"
)

return volume_meshtags
Loading