Skip to content

Conversation

@jorgensd
Copy link
Collaborator

Various Python 3.10 features:

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks very neat @jorgensd

It seems the tests are failing though

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 84.96732% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.95%. Comparing base (c5e3fdb) to head (cc71b65).
⚠️ Report is 91 commits behind head on fenicsx.

Files with missing lines Patch % Lines
src/festim/hydrogen_transport_problem.py 80.00% 16 Missing ⚠️
src/festim/material.py 84.00% 4 Missing ⚠️
src/festim/mesh/mesh.py 90.32% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx    #1029      +/-   ##
===========================================
- Coverage    95.50%   94.95%   -0.55%     
===========================================
  Files           45       44       -1     
  Lines         3089     3111      +22     
===========================================
+ Hits          2950     2954       +4     
- Misses         139      157      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jorgensd
Copy link
Collaborator Author

That looks very neat @jorgensd

It seems the tests are failing though

Fixed now

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jorgensd!

@RemDelaporteMathurin RemDelaporteMathurin merged commit 0f18832 into festim-dev:fenicsx Sep 16, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants