-
Notifications
You must be signed in to change notification settings - Fork 32
Add enums and remove python implementation of transfer meshtags to submesh #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enums and remove python implementation of transfer meshtags to submesh #1029
Conversation
…ctor of the scifem implementation
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks very neat @jorgensd
It seems the tests are failing though
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #1029 +/- ##
===========================================
- Coverage 95.50% 94.95% -0.55%
===========================================
Files 45 44 -1
Lines 3089 3111 +22
===========================================
+ Hits 2950 2954 +4
- Misses 139 157 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed now |
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @jorgensd!
0f18832
into
festim-dev:fenicsx
Various Python 3.10 features:
typing.Optionalis now| None.enums for string based inputs. Should be converted toStrEnumonce Python 3.11 is minimum Python.typing.List->list