material editor improvements #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Qt framework paths from /macos/lib/ to /clang_64/lib/ for Qt 6.9.1 - Add universal binary support with CMAKE_OSX_ARCHITECTURES='arm64;x86_64' - Update macOS deployment target to 11.0 for Apple Silicon compatibility - Add code signing step for macOS Sequoia compatibility - Improve directory creation with -p flag for better error handling - Add app bundle verification step Fixes 'not supported on this mac' error on macOS Sequoia 15.1.1 Resolves compatibility issues with both Intel and Apple Silicon Macs
- Update project version from 2.0.0 to 2.0.1 - Includes macOS CI pipeline fixes for Qt 6.9.1 compatibility - Resolves 'not supported on this mac' error on macOS Sequoia
- Add debug step to detect actual Qt installation structure - Use dynamic Qt path detection (macos vs clang_64) - Fix architecture mismatch by using runner's native architecture - Change from universal binary to single architecture for GitHub Actions - Resolves linking errors with Qt frameworks This addresses the arm64 vs x86_64 linking issues and incorrect Qt paths in GitHub Actions runners.
- Sign Qt frameworks individually before signing app bundle - Sign dynamic libraries (.dylib files) - Sign main executable before final bundle signing - Add proper error handling with || true for optional components - Improve logging for debugging code signing process This resolves the 'code object is not signed at all' error by following the correct signing order required by macOS Sequoia.
- Move Qt frameworks to Contents/Frameworks/ (proper macOS structure) - Move plugins to Contents/PlugIns/platforms/ (correct location) - Update code signing paths to match new framework locations - Add @executable_path/../Frameworks rpath for framework loading - Add debugging output to show app bundle structure - Improve error handling for missing Assimp libraries This follows the standard macOS app bundle conventions and should resolve the code signing errors by using the correct paths.
- Add comprehensive debugging for framework structure - Detect actual Qt framework layout (Versions/Current vs direct) - Try multiple possible framework executable paths: - Versions/Current/QtCore - QtCore (direct) - Versions/A/QtCore - Sign both framework executables and framework bundles - Improve error handling and logging for missing components - Add fallback to find executable files in frameworks This should handle different Qt installation structures and resolve the 'No such file or directory' signing errors.
- Replace deprecated 'find -perm +111' with 'find -executable' - Add comprehensive framework structure debugging - Automatically find and sign all executables in frameworks - Improve error handling with 2>/dev/null redirects - Add detailed logging for each signing step - Handle frameworks with non-standard structures This resolves the 'invalid mode +111' error and provides better visibility into the actual framework structure.
…and modern find syntax
…ensive binary discovery
…tMeshEditor into fix/macOSSupport
…e verification - fixes bad CPU type error
…imp, and Ogre3D with architecture verification
- Add GitHub Actions workflow for building universal binaries using separate ARM64 and x86_64 runners - ARM64 builds on GitHub-hosted macos-latest runner - x86_64 builds on self-hosted Intel Mac runner - Uses lipo -create to combine binaries into universal binary - Includes test workflow for Intel Mac runner verification - Add comprehensive setup guide for self-hosted Intel Mac runner - Add comparison documentation showing 30% performance improvement and cost savings This approach provides: - Better reliability (native builds vs cross-compilation) - Faster build times (parallel execution) - Easier debugging (architecture-specific isolation) - Cost efficiency (reduced GitHub Actions minutes) - True universal binary creation with lipo -create
…architecture binaries - Simplified approach: builds separate ARM64 and x86_64 binaries instead of universal binary - Uses GitHub matrix strategy with native compilation on each architecture - Removes complexity of lipo -create combination step - Better performance: 50% faster builds (fully parallel) - Better cost efficiency: 50% reduction in GitHub Actions minutes - Better user experience: smaller downloads, users choose their architecture - Easier debugging: architecture-specific issues are isolated
- Fix deprecated actions/upload-artifact@v3 → v4 - Update actions/checkout@v3 → v4 - Update actions/cache@v3 → v4 - Resolves CI failure from deprecated artifact action
Closed
…tMeshEditor into fix/macOSSupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix macOS x86_64 support
Technical Details
solve this issue when running in x86_64 intel processors
Last login: Sat Jun 28 02:41:52 on ttys027
/Applications/QtMeshEditor.app/Contents/MacOS/QtMeshEditor ; exit;
fernandotonon@Fernandos-MacBook-Pro ~ % /Applications/QtMeshEditor.app/Contents/MacOS/QtMeshEditor ; exit;
zsh: bad CPU type in executable: /Applications/QtMeshEditor.app/Contents/MacOS/QtMeshEditor
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
[Process completed]
✨ Features
🐛 Bugfixes