Skip to content

feat(pose-lib): apply_pose_masked MCP tool#609

Merged
fernandotonon merged 1 commit into
masterfrom
feat/pose-lib-mcp-apply-masked
May 18, 2026
Merged

feat(pose-lib): apply_pose_masked MCP tool#609
fernandotonon merged 1 commit into
masterfrom
feat/pose-lib-mcp-apply-masked

Conversation

@fernandotonon
Copy link
Copy Markdown
Owner

Exposes D5's apply-with-mask through MCP so an agent can call "apply this facial expression without disturbing the body pose" via JSON-RPC.

What ships

  • PoseLibrary::applyPoseMaskedForSelection(name, boneNames)QStringListQSet glue, resolves entity from SelectionSet's first.
  • apply_pose_masked MCP tool. Args: name (pose), bones (JSON array of bone-name strings).
  • Strict-parse on the bones array: every element must be a string. A non-string slot would silently degrade to empty (toString returns "") and the mask would match unintended bones. Error message names the failing index.

4 new tests

  • Missing name, missing bones, non-array bones, non-string bone-name element.

🤖 Generated with Claude Code

Exposes D5's apply-with-mask through MCP so an agent can call
"apply this facial expression without disturbing the body pose"
via JSON-RPC.

## What ships

- `PoseLibrary::applyPoseMaskedForSelection(name, boneNames)` —
  QStringList→QSet glue, resolves entity from SelectionSet's first.
- `apply_pose_masked` MCP tool. Args: `name` (pose), `bones`
  (JSON array of bone-name strings).
- **Strict-parse** on the bones array: every element must be a
  string. A non-string slot would otherwise silently degrade to
  empty (toString returns "") and the mask would match unintended
  bones. Error message names the failing index.

## 4 new tests

- Missing `name` → error.
- Missing `bones` → error.
- Non-array `bones` (passed a string) → error.
- Non-string bone in the array (an int) → error names the index.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@fernandotonon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 15 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7324835e-f4da-4196-a487-7dfa09d5eebb

📥 Commits

Reviewing files that changed from the base of the PR and between 5202b14 and 7c43a16.

📒 Files selected for processing (5)
  • src/MCPServer.cpp
  • src/MCPServer.h
  • src/MCPServer_test.cpp
  • src/PoseLibrary.cpp
  • src/PoseLibrary.h
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pose-lib-mcp-apply-masked

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@fernandotonon fernandotonon merged commit c8eb1f8 into master May 18, 2026
20 checks passed
@fernandotonon fernandotonon deleted the feat/pose-lib-mcp-apply-masked branch May 18, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant