review(cli): pose --library apply — skinned-entity pick + export breadcrumb#607
Conversation
…dcrumb Two CodeRabbit Major findings on PR #606 (merged). ## Pick first SKINNED entity, not first entity The entity loop stopped at the first `Entity` and then checked `hasSkeleton()`. On multi-entity imports an unskinned helper mesh (collision proxy, prop) often appears first; the old code would reject the apply even though a valid rigged mesh loaded later in the scene. Fix: walk the whole entity list. Track the first-seen entity (any kind) AND the first skinned one separately. Two distinct error paths now: - no entity at all → "Failed to load mesh" - entities exist but none skinned → "no skinned entity — cannot apply a pose" ## Add file.export breadcrumb on the export write The apply flow recorded the mesh import but not the output write. Added a `file.export` breadcrumb naming the target path right before `exportCurrentPose`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
Two CodeRabbit Major findings on PR #606 (merged).
Pick first SKINNED entity, not first entity
Old code stopped at the first
Entitythen checkedhasSkeleton. On multi-entity imports an unskinned helper (collision proxy, prop) often appears first; the apply was rejected even though a valid rigged mesh loaded later.Fix: walk the whole entity list. Track first-seen + first-skinned separately. Two distinct error paths now: "Failed to load mesh" (no entity at all) vs "no skinned entity — cannot apply a pose".
Add file.export breadcrumb on the export write
Old code recorded the import but not the output write. Added a
file.exportbreadcrumb naming the target path beforeexportCurrentPose.🤖 Generated with Claude Code