Skip to content

review(cli): pose --library list — reject non-array poses field#605

Merged
fernandotonon merged 1 commit into
masterfrom
fix/cli-pose-library-isarray
May 18, 2026
Merged

review(cli): pose --library list — reject non-array poses field#605
fernandotonon merged 1 commit into
masterfrom
fix/cli-pose-library-isarray

Conversation

@fernandotonon
Copy link
Copy Markdown
Owner

Codex P2 on PR #604 (merged). The CLI's --library list path checked the schema string but then did root.value("poses").toArray() unconditionally — same silent-empty-on-bad-type bug class as loadPoseLibrary had on PR #602 (fixed in #603), just in the duplicated parse path inside cmdPose.

A schema-matching .poselib file with poses missing or non-array reported "No poses in library" with exit 0 instead of surfacing the corruption. CI/audit workflows relying on non-zero exit would miss the failure.

Fix

Explicit isArray() check after the schema match. Emit Error: malformed 'poses' field in <path> to stderr and return 1.

Manual verification

A {"schema": "qtmesheditor.poselib.v1", "poses": "oops"} file now exits 1 with the expected message.

🤖 Generated with Claude Code

Codex P2 on PR #604 (merged). The CLI's `--library list` path
checked the `schema` string but then did `root.value("poses").toArray()`
unconditionally — same silent-empty-on-bad-type bug class as
loadPoseLibrary had on PR #602 (fixed in #603), just in the
duplicated parse-in-the-CLI path.

A schema-matching `.poselib` file with `poses` missing or
non-array would report "No poses in library" with exit 0 instead
of surfacing the corruption. CI/audit workflows relying on
non-zero exit for invalid libraries would miss the failure.

Fix: explicit `isArray()` check after the schema match, emit
"malformed 'poses' field in <path>" to stderr and return 1.

Manual verification: a `{"schema":"qtmesheditor.poselib.v1","poses":"oops"}`
file now exits 1 with the expected message instead of 0 with a
vacuous result.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@fernandotonon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 2 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22e424a9-c543-48d5-af72-ee8a405ed9dd

📥 Commits

Reviewing files that changed from the base of the PR and between b37eeaa and 5928db1.

📒 Files selected for processing (1)
  • src/CLIPipeline.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cli-pose-library-isarray

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@fernandotonon fernandotonon merged commit 3b811ae into master May 18, 2026
20 checks passed
@fernandotonon fernandotonon deleted the fix/cli-pose-library-isarray branch May 18, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant