fix(typescript): resolve query parameter name conflicts stripping body properties

[jon-fern]

Description

Refs https://github.com/fern-demo/close-typescript-sdk/pull/5

Fixes a bug where request body properties were silently stripped from generated SDK client methods when resolveQueryParameterNameConflicts is enabled and query parameter wire names collide with body property names.

Root Cause

getNonBodyKeys and getNonBodyKeysWithData in GeneratedRequestWrapperImpl.ts always called getPropertyNameOfQueryParameter, which returns { propertyName: wireValue, safeName }. For colliding query params, this produced a destructuring pattern like:

const { assigned_to: filterAssignedTo, is_complete: filterIsComplete, ..._body } = request;

This extracts the body properties assigned_to and is_complete (by their wire names), removing them from the ..._body spread — so the request body is sent as {}.

Fix

Both methods now check getCollidingQueryParamWireValues (only when resolveQueryParameterNameConflicts is enabled) and use getOverriddenPropertyNameOfQueryParameter for colliding params, which returns { propertyName: overriddenName, safeName }. This produces:

const { filterAssignedTo, filterIsComplete, ..._body } = request;

Body properties like is_complete are no longer extracted and remain in _body.

Changes Made

• Modified getNonBodyKeys and getNonBodyKeysWithData to use overridden property names for colliding query parameters
• Added version 3.60.2 to generators/typescript/sdk/versions.yml

Testing

• All 162 existing unit tests in request-wrapper-generator pass
• All 538 existing unit tests in client-class-generator pass
• Verified the unfixed code generates buggy destructuring (assigned_to: filterAssignedTo) and the fixed code generates correct destructuring (filterAssignedTo) by regenerating the query-param-name-conflict seed fixture both with and without the fix

Review Checklist

• Verify that withQueryParameter / getReferenceToQueryParameter in RequestWrapperParameter.ts still resolve aliases correctly — both getPropertyNameOfQueryParameter and getOverriddenPropertyNameOfQueryParameter share the same safeName, so alias lookup should be unaffected, but worth confirming
• Confirm getCollidingQueryParamWireValues is only called when resolveQueryParameterNameConflicts is true (gated at lines 519 and 546)
• Note that getCollidingQueryParamWireValues is now called twice per endpoint (once in each method) — this is harmless for small query param lists but worth noting

Link to Devin session: https://app.devin.ai/sessions/d27799c513934481a4042a6818cffd00
Requested by: @jon-fern

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}