feat(cli): add missing-redirects rule to fern check#14132
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
aditya-arolkar-swe
approved these changes
Apr 2, 2026
eeb9d32 to
31cfb66
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: FER-9171
Add a new
fern checkrule,missing-redirects, that compares the current docs navigation against the previously published markdown slug table stored in FDR. The rule detects when a page that was previously published has either been removed entirely or moved to a new slug without a corresponding redirect indocs.yml, helping prevent broken historical docs URLs after publish.The rule is configurable through
check.rulesindocs.yml, where users can set it towarnorerror, and it follows the standard docs check severity behavior. In practice this means the rule defaults to warning behavior, but can be promoted to an error when teams want redirect coverage to be enforced before publishing.Because the rule depends on prior published state, it makes an authenticated network call to FDR during validation. The implementation handles first-publish, missing auth, offline/network failure, and timeout cases gracefully so the behavior remains consistent with the configured severity. This PR also extracts the core diffing and redirect-matching logic into unit-testable helpers and aligns slug generation behavior with the backend, including changelog-specific handling.
Changes Made
missing-redirectsdocs validation rule and wired it intocheck.rulesconfiguration indocs.ymlTesting