fix(cli): use OVERRIDE_FDR_ORIGIN for air-gap detection in self-hosted environments#11817
Closed
thesandlord wants to merge 1 commit intomainfrom
Closed
fix(cli): use OVERRIDE_FDR_ORIGIN for air-gap detection in self-hosted environments#11817thesandlord wants to merge 1 commit intomainfrom
thesandlord wants to merge 1 commit intomainfrom
Conversation
…ironments Co-Authored-By: Sandeep Dinesh <sandeep@buildwithfern.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs: Slack thread from @thesandlord about
fern generate --docsstalling in air-gapped environmentsLink to Devin run: https://app.devin.ai/sessions/dcec6a094378444b94e7253cc9c06cf4
Requested by: Sandeep Dinesh (@thesandlord)
In self-hosted environments, the air-gap detection was checking connectivity to
https://registry.buildwithfern.com/health(fromDEFAULT_FDR_ORIGIN) instead of the local FDR server athttp://localhost:8080/health(fromOVERRIDE_FDR_ORIGIN). This caused the CLI to incorrectly detect air-gapped mode even when the local FDR server was reachable.The FDR client already respects
OVERRIDE_FDR_ORIGIN, but the air-gap detection did not.Changes Made
publishDocs.tsandrunRemoteGenerationForGenerator.tsto useOVERRIDE_FDR_ORIGIN ?? DEFAULT_FDR_ORIGINfor air-gap detection, matching the FDR client behaviorTesting
Human Review Checklist
OVERRIDE_FDR_ORIGIN ?? DEFAULT_FDR_ORIGIN ?? fallback) is correctDEFAULT_FDR_ORIGINusage in air-gap detection)