fix(ci): expand pre-build step to include more foundational packages#11736
Closed
davidkonigsberg wants to merge 1 commit intomainfrom
Closed
fix(ci): expand pre-build step to include more foundational packages#11736davidkonigsberg wants to merge 1 commit intomainfrom
davidkonigsberg wants to merge 1 commit intomainfrom
Conversation
The previous pre-build step only built @fern-api/core-utils, but race conditions were still occurring because other foundational packages (path-utils, fs-utils, logger) were being built in parallel with packages that depend on them. This change: - Adds path-utils (leaf package with no dependencies) - Adds fs-utils (depends on core-utils, path-utils) - Adds logger (depends on core-utils) - Uses --concurrency 1 to ensure sequential builds Building these packages sequentially before the parallel compilation ensures their output files are fully written before dependent packages start compiling, preventing TS2306 'is not a module' errors. Co-Authored-By: David Konigsberg <davidakonigsberg@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
davidkonigsberg
deleted the
devin/1769197543-fix-prebuild-race-condition
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs: https://github.com/fern-api/fern/actions/runs/21298381788/job/61309835788
Fixes intermittent CI failures where TypeScript compilation fails with
TS2306: File is not a moduleerrors forcore-utils/lib/index.d.ts.Changes Made
path-utils,fs-utils, andloggerin addition tocore-utils--concurrency 1to ensure sequential builds of foundational packagesRoot Cause Analysis
The previous pre-build step only built
@fern-api/core-utils, but race conditions were still occurring because:path-utils(a leaf package) was being built in parallel with packages that depend on itrust-basecompiled, it triggered compilation oflogger, which tried to import fromcore-utilswhile files were potentially still being writtenThe fix pre-builds all foundational packages sequentially before parallel compilation begins.
Testing
Human Review Checklist
core-utilsandpath-utilsare leaf packages;fs-utilsdepends on both;loggerdepends oncore-utilsRequested by: David Konigsberg (@davidkonigsberg)
Link to Devin run: https://app.devin.ai/sessions/557fd9a0710846909fef8a0351ef63ea