fix(java): update palantir-java-format to 2.80.0 to fix JDK 25 EA compatibility#10002
Closed
devin-ai-integration[bot] wants to merge 5 commits intomainfrom
Closed
fix(java): update palantir-java-format to 2.80.0 to fix JDK 25 EA compatibility#10002devin-ai-integration[bot] wants to merge 5 commits intomainfrom
devin-ai-integration[bot] wants to merge 5 commits intomainfrom
Conversation
…patibility This fixes the NoSuchMethodError with getDiagnostics() that occurs when running spotless with JDK 25 EA. The error was caused by an incompatibility in palantir-java-format 2.46.0 with the Java compiler internals in JDK 25. Changes: - Updated palantir-java-format from 2.46.0 to 2.80.0 in build.gradle - Updated spotless plugin from 6.25.0 to 7.2.1 in build.gradle - Updated generated build.gradle to use palantir-java-format 2.80.0 - Updated generated build.gradle to use spotless plugin 7.2.1 The fix was released in palantir-java-format 2.71.0 (July 16, 2025) and is included in version 2.80.0 (October 15, 2025). Fixes: palantir/palantir-java-format#1366 Co-Authored-By: tanmay.singh@buildwithfern.com <tstanmay13@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…rmat versions All generated build.gradle files now use: - spotless plugin 7.2.1 (was 6.11.0) - palantir-java-format 2.80.0 (was unspecified, defaulting to old version) This updates the seed snapshots to match the generator changes. Co-Authored-By: tanmay.singh@buildwithfern.com <tstanmay13@gmail.com>
…ss/palantir-java-format versions Co-Authored-By: tanmay.singh@buildwithfern.com <tstanmay13@gmail.com>
Co-Authored-By: tanmay.singh@buildwithfern.com <tstanmay13@gmail.com>
Co-Authored-By: tanmay.singh@buildwithfern.com <tstanmay13@gmail.com>
Contributor
|
This PR is stale because it has been open 25 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Contributor
|
This PR was closed because it has been inactive for 5 days after being marked stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: N/A (customer issue reported via Slack)
Link to Devin run: https://app.devin.ai/sessions/bc7b796ece494de58f3ff09a4b925bea
Requested by: tanmay.singh@buildwithfern.com (@tstanmay13)
Fixes a
NoSuchMethodErrorthat customers encounter when building generated Java SDKs with JDK 25 EA. The error occurs because palantir-java-format 2.46.0 is incompatible with JDK 25's internal compiler API changes:This was fixed in palantir-java-format 2.71.0 (July 2024) per palantir/palantir-java-format#1367.
Changes Made
Generator Configuration (
generators/java/build.gradle):Generated SDK Template (
AbstractGeneratorCli.java):palantirJavaFormat()→palantirJavaFormat('2.80.0')to explicitly pin versionSeed Snapshots:
Note: The intentional version split (spotless 7.2.1 for generator, 6.11.0 for generated SDKs) is required because:
Testing
--skip-scripts)Review Checklist
Version Split Logic: Confirm that using spotless 7.2.1 for the generator (Java 11) and 6.11.0 for generated SDKs (Java 8 target) is correct and won't cause issues
CI Test Results: MUST wait for CI to pass before merging. The seed tests will validate:
Formatting Behavior: Palantir-java-format 2.80.0 may format code differently than 2.46.0. Any cosmetic changes in generated Java code are expected but should be reviewed if CI shows differences
Backward Compatibility: Verify this doesn't break customers using Java 8-21 for builds (spotless 6.11.0 supports Java 8+)
Incomplete Snapshot Updates: This PR only updates build.gradle files. If the formatter produces different output, those changes will appear when CI runs the full seed tests
Known Limitations:
--skip-scriptsCustomer Impact
Positive:
Neutral: