Skip to content

chore: update vite-plus and vite-plus-test to 0.1.13-alpha.5#3

Draft
fengmk2 wants to merge 4 commits intomainfrom
test-vite-plus-alpha
Draft

chore: update vite-plus and vite-plus-test to 0.1.13-alpha.5#3
fengmk2 wants to merge 4 commits intomainfrom
test-vite-plus-alpha

Conversation

@fengmk2
Copy link
Owner

@fengmk2 fengmk2 commented Mar 20, 2026

🔗 Linked issue

🧭 Context

📚 Description

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's core development dependencies, vite-plus and vite-plus-test, to their latest alpha release. This ensures the project leverages the most recent features, bug fixes, and performance enhancements from these tools and their underlying dependencies, maintaining a modern and robust development environment.

Highlights

  • Dependency Updates: Updated vite-plus and vite-plus-test to version 0.1.13-alpha.5 in package.json.
  • Lockfile Synchronization: Synchronized pnpm-lock.yaml to reflect the updated vite-plus and vite-plus-test versions, including numerous transitive dependency updates for @oxc-project, @oxfmt, and @oxlint packages.
  • Dependency Cleanup: Removed a deprecated warning for glob@11.1.0 and older versions of @oxlint/binding-* packages from pnpm-lock.yaml.
  • Tooling Updates: Updated the cac dependency version within pnpm-lock.yaml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates vite-plus and vite-plus-test dependencies to version 0.1.13-alpha.5. My review focuses on two main concerns. Firstly, the adoption of an alpha version, which could introduce instability. It would be beneficial to add context to the pull request description explaining the rationale for this upgrade. Secondly, there's a potential inconsistency with the overrides in pnpm-workspace.yaml, which still point to older versions. This could result in multiple versions of the same dependency within the project. I've added specific comments with suggestions to address these points.

"virtua": "0.48.8",
"vite-plugin-pwa": "1.2.0",
"vite-plus": "0.1.12",
"vite-plus": "0.1.13-alpha.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This updates vite-plus to an alpha version (0.1.13-alpha.5). Using pre-release versions can be risky due to potential instability. It would be helpful to clarify in the PR description why this alpha version is necessary.

Additionally, pnpm-workspace.yaml has an override for vite to npm:@voidzero-dev/vite-plus-core@0.1.12. Since vite-plus depends on @voidzero-dev/vite-plus-core, this could lead to two different versions of @voidzero-dev/vite-plus-core in the project. If the goal is to update this dependency across the workspace, consider updating the override in pnpm-workspace.yaml to npm:@voidzero-dev/vite-plus-core@0.1.13-alpha.5 for consistency.

"typescript": "5.9.3",
"unplugin-vue-markdown": "30.0.0",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.12",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.13-alpha.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to vite-plus, this updates vitest to an alpha version of @voidzero-dev/vite-plus-test. The pnpm-workspace.yaml file also has an override for vitest pointing to version 0.1.12. To ensure consistency across the workspace, it would be best to update this override to npm:@voidzero-dev/vite-plus-test@0.1.13-alpha.5 as well.

fengmk2 added 3 commits March 20, 2026 09:41
Known issue: Nuxt build fails with "Failed to parse JSON file" error
from the native builtin:vite-json plugin in vite-plus-core. This is
a regression in the Rolldown binary bundled in 0.1.13-alpha.5.
@fengmk2
Copy link
Owner Author

fengmk2 commented Mar 20, 2026

Root Cause Analysis: builtin:vite-json regression in vite-plus-core@0.1.13-alpha.5

The builtin:vite-json plugin in the Rolldown native binary bundled in vite-plus-core@0.1.13-alpha.5 has a regression that causes it to fail parsing valid JSON files.

Error

[vite:json] [plugin vite:json] i18n/locales/ar-EG.json: Failed to parse JSON file.

Even for a tiny 34-byte file: {"$schema": "../schema.json"}

Key Evidence

  1. Confirmed regression: CI passes with 0.1.12, fails with 0.1.13-alpha.5
  2. Valid JSON: All locale files are valid JSON (verified with JSON.parse() and Python json.load())
  3. Native binary issue: The viteJsonPlugin JS wrapper is identical between versions — only the native Rolldown binary changed (@oxc-project/* upgraded from 0.115.00.120.0, new oxcRuntimePlugin() added)
  4. Nuxt-specific trigger: Standalone vite-plus builds work fine. The bug is only triggered when building through Nuxt's pipeline (~100 plugins, environment/builder API). Could not reproduce outside of Nuxt despite extensive testing with:
    • build() with all locale files
    • createBuilder() with client + SSR environments
    • Vue + VueI18n plugins + 100 dummy plugins
    • Various json.stringify / namedExports config combinations
  5. Not a config issue: Tested json: { stringify: false, namedExports: false } — still fails. The resolved config is identical between versions ({"namedExports":true,"stringify":"auto"})
  6. Also fixed the napi mismatch: Had to add pnpm.overrides for @voidzero-dev/vite-plus-core to prevent two incompatible versions (0.1.12 + 0.1.13-alpha.5) from loading simultaneously, which caused a separate Failed to convert napi value into rust type 'bool' error

Next Steps

File a bug against vite-plus-core / Rolldown: the builtin:vite-json plugin in 0.1.13-alpha.5 fails to parse valid JSON files when used in a complex plugin pipeline (like Nuxt with @nuxtjs/i18n). Reproducible with npx nuxt build on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants