-
Notifications
You must be signed in to change notification settings - Fork 52
spec: add missing license files #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jamacku, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a packaging compliance detail by ensuring that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the missing license file to four subpackages (initscripts-rename-device, initscripts-service, netconsole-service, and readonly-root) within the initscripts.spec file. The use of the %license COPYING directive is the proper modern approach and ensures license compliance for these packages. I have one minor suggestion to improve formatting consistency across the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds missing %license COPYING directives to four subpackages in the RPM spec file: initscripts-rename-device, initscripts-service, netconsole-service, and readonly-root. These subpackages were missing license file declarations while the main initscripts package already had one.
- Adds
%license COPYINGdirective to each of the four subpackages - Ensures compliance with RPM packaging guidelines for license file distribution
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.