Move extras option creation to register_config, do it after tox itself#91
Merged
hroncok merged 3 commits intofedora-python:masterfrom May 6, 2026
Merged
Move extras option creation to register_config, do it after tox itself#91hroncok merged 3 commits intofedora-python:masterfrom
hroncok merged 3 commits intofedora-python:masterfrom
Conversation
In tox < 4.44 we still need to do it.
In tox 4.44+ apparently we don't need it, but if we check
if "extras" not in self.conf
*after* super().register_config(), we are good.
Note that the register_config() method even sounds like a better place to,
well... register a config option. It has been around since the beginning of tox 4.
Ref: tox-dev/tox@741362fb52
Fixes fedora-python#90
Member
Author
|
All the tox4 test configs have passed and this change only changes tox4 code. I don't have the energy to deal with tox3 right now -- the failure is non-blocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In tox < 4.44 we still need to do it.
In tox 4.44+ apparently we don't need it, but if we check
if "extras" not in self.conf
after super().register_config(), we are good.
Note that the register_config() method even sounds like a better place to, well... register a config option. It has been around since the beginning of tox 4. Ref: tox-dev/tox@741362fb52
Fixes #90