Changed the RETURN_STRING() macro to return None instead of False, to make it more Pythonish

David Sommerseth · David Sommerseth · commit b74c47dc5ea7 · 2009-09-07T17:35:54.000+02:00
diff --git a/python-ethtool/etherinfo_obj.c b/python-ethtool/etherinfo_obj.c
@@ -68,13 +68,13 @@ int _ethtool_etherinfo_init(etherinfo_py *self, PyObject *args, PyObject *kwds)
 }
 
 /**
- * Null safe PyString_FromString() wrapper.  If input string is NULL, a False value will be returned
+ * NULL safe PyString_FromString() wrapper.  If input string is NULL, None will be returned
  *
  * @param str Input C string (char *)
  *
- * @return Returns a PyObject with either the input string wrapped up, or a Python False value.
+ * @return Returns a PyObject with either the input string wrapped up, or a Python None value.
  */
-#define RETURN_STRING(str) (str ? PyString_FromString(str) : Py_False);
+#define RETURN_STRING(str) (str ? PyString_FromString(str) : Py_None);
 
 /**
  * ethtool.etherinfo function for retrieving data from a Python object.

Original file line number	Diff line number	Diff line change
`@@ -68,13 +68,13 @@ int _ethtool_etherinfo_init(etherinfo_py self, PyObject args, PyObject *kwds)`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`/**`
`71`		`- * Null safe PyString_FromString() wrapper. If input string is NULL, a False value will be returned`
	`71`	`+ * NULL safe PyString_FromString() wrapper. If input string is NULL, None will be returned`
`72`	`72`	`*`
`73`	`73`	`* @param str Input C string (char *)`
`74`	`74`	`*`
`75`		`- * @return Returns a PyObject with either the input string wrapped up, or a Python False value.`
	`75`	`+ * @return Returns a PyObject with either the input string wrapped up, or a Python None value.`
`76`	`76`	`*/`
`77`		`-#define RETURN_STRING(str) (str ? PyString_FromString(str) : Py_False);`
	`77`	`+#define RETURN_STRING(str) (str ? PyString_FromString(str) : Py_None);`
`78`	`78`
`79`	`79`	`/**`
`80`	`80`	`* ethtool.etherinfo function for retrieving data from a Python object.`