Make Python dir() function work with ethtool.etherinfo objects

David Sommerseth · David Sommerseth · commit 38a0b2a9adab · 2009-09-07T17:32:31.000+02:00
diff --git a/python-ethtool/etherinfo_obj.c b/python-ethtool/etherinfo_obj.c
@@ -108,8 +108,7 @@ PyObject *_ethtool_etherinfo_getter(etherinfo_py *self, PyObject *attr_o)
 	} else if( strcmp(attr, "ipv6_netmask") == 0 ) {
 		return PyInt_FromLong(self->info->ipv6_netmask);
 	}
-	PyErr_SetString(PyExc_AttributeError, "Unknown attribute name");
-	return NULL;
+	return PyObject_GenericGetAttr((PyObject *)self, attr_o);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -108,8 +108,7 @@ PyObject _ethtool_etherinfo_getter(etherinfo_py self, PyObject *attr_o)`
`108`	`108`	`} else if( strcmp(attr, "ipv6_netmask") == 0 ) {`
`109`	`109`	`return PyInt_FromLong(self->info->ipv6_netmask);`
`110`	`110`	`}`
`111`		`- PyErr_SetString(PyExc_AttributeError, "Unknown attribute name");`
`112`		`- return NULL;`
	`111`	`+ return PyObject_GenericGetAttr((PyObject *)self, attr_o);`
`113`	`112`	`}`
`114`	`113`
`115`	`114`