-
Notifications
You must be signed in to change notification settings - Fork 36
feat: add parseOobNotes to walletDirector #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
2dc6eb0 to
dfb96a9
Compare
|
Size Change: +42 B (0%) Total Size: 7.44 MB
ℹ️ View Unchanged
|
elsirion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention the intended flow of "join if federation unknown" in the docs please?
| ### parseOobNotes(notes) | ||
|
|
||
| > **parseOobNotes**(`notes`): `Promise`\<`ParsedNoteDetails`\> | ||
| Parses OOB notes and retrieves their details. It allows you to inspect the contents of OOB notes before redeeming them. | ||
|
|
||
| #### Parameters | ||
|
|
||
| • **notes**: `string` | ||
|
|
||
| #### Returns | ||
|
|
||
| `Promise`\<`ParsedNoteDetails`\> | ||
|
|
||
| The parsed note details containing `total_amount`, `federation_id_prefix`, and `note_counts`. | ||
|
|
||
| #### Defined in | ||
|
|
||
| [WalletDirector.ts:205](https://github.com/fedimint/fedimint-sdk/tree/main/packages/core/src/WalletDirector.ts#L205) | ||
|
|
||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Why not mention the invite code? That was the whole point of adding this fn.
dfb96a9 to
97911ce
Compare
chore: fix parseOobNotes
f3a85e8 to
603389b
Compare
603389b to
2fe71b4
Compare
elsirion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's gooooo! Do we need to bump any WASM reference @MrImmortal09?
|
We do need to bump WASM, but the WASM on master is currently broken ,I’ve been debugging it this week. I’ll open a separate PR as soon as I finish debugging the issue, and we can also backport the relevant commits and reference release v0.9. |
|
Great work @MrImmortal09! It'd be good to add some tests for |
Closes #224