Skip to content

Conversation

@MrImmortal09
Copy link
Member

Closes #224

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: 2fe71b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MrImmortal09 MrImmortal09 marked this pull request as ready for review December 8, 2025 08:46
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Size Change: +42 B (0%)

Total Size: 7.44 MB

Filename Size Change
packages/core/dist/index.js 1.55 kB +24 B (+1.57%)
packages/transport-web/dist/worker.js 712 B +8 B (+1.14%)
packages/types/dist/index.js 528 B +10 B (+1.93%)
ℹ️ View Unchanged
Filename Size
packages/core/dist/testing.js 2.77 kB
packages/create-fedimint-app/dist/index.mjs 17 kB
packages/react/dist/index.js 1.31 kB
packages/transport-web/dist/index.js 287 B
packages/types/dist/jsonClientConfig.js 75 B
packages/types/dist/utils.js 64 B
packages/wasm-bundler/fedimint_client_wasm_bg.wasm 3.71 MB
packages/wasm-web/fedimint_client_wasm_bg.wasm 3.71 MB

compressed-size-action

Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention the intended flow of "join if federation unknown" in the docs please?

Comment on lines 197 to 217
### parseOobNotes(notes)

> **parseOobNotes**(`notes`): `Promise`\<`ParsedNoteDetails`\>
Parses OOB notes and retrieves their details. It allows you to inspect the contents of OOB notes before redeeming them.

#### Parameters

**notes**: `string`

#### Returns

`Promise`\<`ParsedNoteDetails`\>

The parsed note details containing `total_amount`, `federation_id_prefix`, and `note_counts`.

#### Defined in

[WalletDirector.ts:205](https://github.com/fedimint/fedimint-sdk/tree/main/packages/core/src/WalletDirector.ts#L205)

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why not mention the invite code? That was the whole point of adding this fn.

@MrImmortal09 MrImmortal09 force-pushed the om/parseOOB branch 3 times, most recently from f3a85e8 to 603389b Compare December 10, 2025 17:25
Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooooo! Do we need to bump any WASM reference @MrImmortal09?

@MrImmortal09
Copy link
Member Author

MrImmortal09 commented Dec 11, 2025

 We do need to bump WASM, but the WASM on master is currently broken ,I’ve been debugging it this week. I’ll open a separate PR as soon as I finish debugging the issue, and we can also backport the relevant commits and reference release v0.9.

@MrImmortal09 MrImmortal09 enabled auto-merge (squash) December 11, 2025 21:50
@MrImmortal09 MrImmortal09 merged commit e160082 into main Dec 11, 2025
15 of 17 checks passed
@MrImmortal09 MrImmortal09 deleted the om/parseOOB branch December 11, 2025 22:40
@alexlwn123
Copy link
Member

Great work @MrImmortal09! It'd be good to add some tests for parseOobNotes in a follow-on PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move parseNotes from MintService to Core

4 participants