Skip to content

Conversation

@pkfec
Copy link
Contributor

@pkfec pkfec commented Dec 11, 2025

Summary (required)

Add q_exclude to the args to allow filter by the q_exclude parameter from the rulemaking/search API endpoint.

Required reviewers

2 developers

Impacted areas of the application

  • rulemaking/search endpoint

Screenshots

Screenshot 2025-12-10 at 9 01 05 PM

How to test

PDF's are available on Dev S3 here

@pkfec pkfec self-assigned this Dec 11, 2025
@pkfec pkfec changed the title [wip] Add q_exclude filter for rulemakings Add q_exclude filter for rulemakings Dec 11, 2025
@pkfec pkfec moved this to 👀 Ready in Website project Dec 11, 2025
@pkfec pkfec marked this pull request as draft December 11, 2025 04:35
@pkfec pkfec force-pushed the feature/6359-rulemaking-q-exclude branch from 2236aa5 to 5392966 Compare December 16, 2025 13:32
@pkfec pkfec marked this pull request as ready for review December 16, 2025 13:39
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.98%. Comparing base (0ddc796) to head (5392966).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6428      +/-   ##
===========================================
+ Coverage    86.95%   86.98%   +0.02%     
===========================================
  Files           98       98              
  Lines         9976     9978       +2     
===========================================
+ Hits          8675     8679       +4     
+ Misses        1301     1299       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JonellaCulmer JonellaCulmer added this to the 30.4 milestone Dec 16, 2025
Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. good job. Thanks

Copy link
Contributor

@tmpayton tmpayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @pkfec!

Copy link
Contributor

@johnnyporkchops johnnyporkchops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@fec-jli fec-jli merged commit 164b81c into develop Dec 29, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from 👀 Ready to ✅ Done in Website project Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

q_exclude not working as expected on rulemaking endpoint

6 participants