-
Notifications
You must be signed in to change notification settings - Fork 111
Add q_exclude filter for rulemakings #6428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2236aa5 to
5392966
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6428 +/- ##
===========================================
+ Coverage 86.95% 86.98% +0.02%
===========================================
Files 98 98
Lines 9976 9978 +2
===========================================
+ Hits 8675 8679 +4
+ Misses 1301 1299 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fec-jli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. good job. Thanks
tmpayton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @pkfec!
johnnyporkchops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Summary (required)
Add
q_excludeto the args to allow filter by theq_excludeparameter from therulemaking/searchAPI endpoint.Required reviewers
2 developers
Impacted areas of the application
rulemaking/searchendpointScreenshots
How to test
Test q-exclude variable:
(2013-04 and 2013-02 rulemaking documents contain this word)
PDF's are available on Dev S3 here