Skip to content

Conversation

@rfultz
Copy link
Contributor

@rfultz rfultz commented Aug 20, 2025

Summary

  • Resolves #

Updating how the timeline page and its entries could work

Required reviewers

  • Front-end

Impacted areas of the application

  • Updated the FecTimelinePage model
  • Updated the FecTimelinePage template
  • Created the FecTimelineItem page model and its template
  • Registered a special admin view for FecTimelineItem pages and put it inside the News and Updates section in Wagtail
  • Flake8 found an error in the home/wagtail_hooks.py so I fixed that, too

Screenshots

Editing the timeline
image

Child pages of the timeline
image

Timeline items' list under News and Updates
image

Editing a timeline item
image

Related PRs

None

How to test

  • Pull the branch
  • npm run build
  • ./manage.py migrate (We shouldn't need makemigrations)
  • ./manage.py runserver
  • Log in to the Wagtail interface
  • If you don't have a page under About that's of the FecTimelinePage template, create one (under About, the only place it can live)
  • If you already have one, edit it
    • It should have the body field, a message at the bottom about its child pages, and an accurate preview
  • Add a child page (for the FecTimelinePage)
  • Populate the fields
    • The preview should populate when all required fields have values
    • The preview should work (e.g. clicking the <summary> should open the <details>)
    • The preview should change as changes are made, including whether it starts in an 'open' state
    • The author/editor directions/tips at the bottom should be clear and free of errors
    • The preview should included a faded-out entry about the current one and two below it, one for the same year and another in a later year (to should the current entry in context)
  • Publish the timeline item page
  • Create another timeline item or more—leave one as a draft
  • Back to the FecTimelinePage
  • Published timeline items should appear in the list
  • Draft timeline items should not appear on the page
  • The page functions in preview
  • Category filtering works correctly
  • Back to the Wagtail News and Updates column
    • FEC Timeline Items appear under News and Updates
    • Going into the FEC Timeline items option, the list looks correct (i.e. a title column (I couldn't replicate the functionality in other ways), a Summary column, Entry date, Categories, Updated, and Status)
    • The FEC Timeline items page/list sorting works as expected

NOTE
Because of the fix to register_viewset in home/wagtail_hooks.py,:

  • Double check that the Authors lists are identical for localhost as for www
  • Double check that the News and Updates lists are identical between localhost and www

@rfultz rfultz added this to the 29.2 milestone Aug 20, 2025
@rfultz rfultz requested a review from patphongs August 20, 2025 17:20
@rfultz rfultz self-assigned this Aug 20, 2025
@rfultz rfultz moved this to 👀 Ready in Website project Aug 20, 2025
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 76.05634% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.54%. Comparing base (efe0a99) to head (a3b0751).
⚠️ Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
fec/home/models.py 67.30% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6859      +/-   ##
===========================================
- Coverage    79.65%   79.54%   -0.11%     
===========================================
  Files          239      240       +1     
  Lines         5279     5334      +55     
===========================================
+ Hits          4205     4243      +38     
- Misses        1074     1091      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfultz rfultz modified the milestones: 29.2, 29.6 Sep 16, 2025
@patphongs patphongs modified the milestones: 29.6, 30.2, 30.3 Nov 20, 2025
@patphongs patphongs modified the milestones: 30.3, 30.5 Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 Ready

Development

Successfully merging this pull request may close these issues.

3 participants