Skip to content

Conversation

@johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Dec 12, 2023

Summary (required)

Template filter to remove the FEC | prefix and - FEC.gov suffix from search.gov, site-search results titles.

Required reviewers

one frontend, one UX/content

Impacted areas of the application

Site search result listings titles

modified:   home/templatetags/filters.py
modified:   search/templates/search/search.html 

Screenshots

(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)

How to test

  • Checkout and run branch
  • export SEARCHGOV_API_ACCESS_KEY=<get key from CF env vars>
  • Test global site-search searching on your local.
  • The results on your local will be prod (www) urls, but you can compare local search results to the same search results on prod to verify that the pre/suf fixes were stripped out on your local's search results page.
  • Note: Because of match-highlighting, searches that include the strings "FEC" or "FEC.gov" in the search-term will not have these patterns removed from the search results.

System architecture updates (if applicable)

(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)

@johnnyporkchops johnnyporkchops changed the title [DRAFT] Remove prefix and suffix from site-search results [DRAFT] Remove prefix and suffix from site-search result titles Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Research removal of "FEC | "and " - FEC.gov" from global search results titles

2 participants