-
Notifications
You must be signed in to change notification settings - Fork 1
Use PSR-3 Logger instead of custom solution #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
amazing! all tests are passing! 🚀 I will take a look tomorrow (Sunday) one more time aim for merge and release. thanks a lot! |
|
Please hold on with merging that PR. I would like to add one more thing:
|
|
@fahad19 I've made changes I mentioned above. Few test cases were deleted due to untestable STDOUT stream. Working of that solution is delivered by language itself. |
|
will wait for your green light here before going for the merge. |
|
Rebased. IMO can be merged |
|
landed in v0.3.0: https://github.com/featurevisor/featurevisor-php/releases/tag/v0.3.0 thanks a lot, @Greg0! once you feel it's time, would be great to also update the example PHP app here to new users can see real world example of latest SDK being used in an app: https://github.com/featurevisor/featurevisor-example-php |
Summary
Replace the custom logger implementation with PSR-3 compliant logging interfaces, bringing the PHP SDK in line with established PHP logging standards and improving interoperability with existing logging solutions.
What Changed
Core Changes
Psr\Log\LoggerInterfaceand usesLoggerTraitwarn,error, etc.) to PSR-3 standard levels (LogLevel::WARNING,LogLevel::ERROR, etc.)Dependencies
psr/log^2.0: Core PSR-3 logging interface dependencyAPI Updates
warn()calls towarning()throughout codebaseLoggerInterfacetype hints across all classesDocumentation
No breaking changes for basic usage. The SDK maintains its existing logging behavior by default, but now accepts any PSR-3 compliant logger:
This change positions the Featurevisor PHP SDK as a more mature, standards-compliant library that integrates seamlessly with the broader PHP ecosystem.