fix: celery-worker now receives context from http request for csv reports#43
Open
efortish wants to merge 1 commit into
Open
fix: celery-worker now receives context from http request for csv reports#43efortish wants to merge 1 commit into
efortish wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/fccn/nau-technical/issues/862
enrolled_students_features()was recomputing the list of student fields by callingget_student_features_with_custom()inside the Celery task, which relies onget_current_request()to resolve the site configuration. Since Celery workers have no HTTP request context,configuration_helpers.get_value()always returned the default empty list, causing custom attributes (e.g.nau_nif) to be absent from the student dict while still present in the CSV header — resulting in misaligned columns. The fix uses thefeaturesparameter directly (already computed correctly during the HTTP request and serialized into the task input) instead of re-querying site config in the wrong context.