Skip to content

chore: bump toolchain and quiet typecheck noise#44

Merged
fathiraz merged 2 commits into
mainfrom
chore/toolchain-typecheck-clean
Jun 2, 2026
Merged

chore: bump toolchain and quiet typecheck noise#44
fathiraz merged 2 commits into
mainfrom
chore/toolchain-typecheck-clean

Conversation

@fathiraz
Copy link
Copy Markdown
Owner

@fathiraz fathiraz commented Jun 2, 2026

Summary

  • Bump TypeScript, Vitest, Vite, ESLint, and related dev dependencies
  • Pin pnpm 11.5.0 and refresh the lockfile
  • Add pnpm minimumReleaseAgeExclude entries so Vitest 4.1.8 can install under release-age policy
  • Inline Primer packages in Vitest for stable dependency pre-bundling

Changes

package.json / pnpm-lock.yaml

  • TypeScript 6, Vitest 4.1.8, Vite 8.0.16, ESLint 10, and aligned runtime/dev bumps
  • packageManager set to pnpm@11.5.0

pnpm-workspace.yaml

  • minimumReleaseAgeExclude for Vitest 4.1.8 stack and Vite 8.0.16

vitest.config.ts

  • server.deps.inline for @primer/react, @primer/octicons-react, @primer/live-region-element

Test Plan

  • pnpm install completes without release-age blocks on Vitest
  • pnpm typecheck finishes with no warning spam in output
  • pnpm test (Vitest) still passes with Primer-heavy tests

Summary by cubic

Upgrade TypeScript/vitest/vite/eslint and pin pnpm@11.5.0 to reduce typecheck noise and keep installs unblocked. Also align CI workflows and inline Primer packages in vitest for more stable tests.

  • Dependencies

    • Bumped to TypeScript 6, vitest 4.1.8, vite 8.0.16, eslint 10; refreshed lockfile.
    • Set packageManager to pnpm@11.5.0 and updated CI/coverage/release workflows to use it.
    • Added minimumReleaseAgeExclude for the vitest 4.1.8 stack and vite 8.0.16.
  • Refactors

    • Inlined Primer deps in vitest (@primer/react, @primer/octicons-react, @primer/live-region-element) to stabilize pre-bundling and test runs.

Written for commit 78fcadc. Summary will update on new commits.

Review in cubic

TypeScript 6 and refreshed Vitest/Vite/ESLint deps reduce compiler
warnings during pnpm typecheck. pnpm minimumReleaseAgeExclude unblocks
Vitest 4.1.8 installs; Vitest inlines Primer packages for stable tests.
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor auto review

Found 1 actionable issue(s) on changed lines.

Toolchain bump (TypeScript 6, Vitest 4.1.8, Vite 8.0.16, ESLint 10, pnpm 11.5.0) with sensible Vitest Primer deps.inline and minimumReleaseAgeExclude entries. Action: packageManager is now pnpm@11.5.0, but CI still installs/runs pnpm@10.32.1 (.github/workflows/ci.yml, coverage.yml, release.yml), so CI may not match local/corepack installs or catch pnpm 11-specific install policy issues.

Generated automatically when this PR was submitted using Cursor CLI with --model auto.

Comment thread package.json
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

Bump pnpm in ci, coverage, and release workflows from 10.32.1 to
11.5.0 to match packageManager on PR #44 toolchain bump.
@fathiraz fathiraz merged commit 8180402 into main Jun 2, 2026
3 checks passed
@fathiraz fathiraz deleted the chore/toolchain-typecheck-clean branch June 2, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant