Skip to content

fix(ui): apply BulkFlyout bodySx to body container#43

Merged
fathiraz merged 1 commit into
feat/bulk-actions-flyoutsfrom
cursor/fix-bulk-flyout-bodysx-015f
Jun 1, 2026
Merged

fix(ui): apply BulkFlyout bodySx to body container#43
fathiraz merged 1 commit into
feat/bulk-actions-flyoutsfrom
cursor/fix-bulk-flyout-bodysx-015f

Conversation

@fathiraz
Copy link
Copy Markdown
Owner

@fathiraz fathiraz commented Jun 1, 2026

Moves bodySx from the flyout shell Box to the scrollable body Box (rgp-bulk-flyout-body), matching the documented prop contract.

Addresses review on #38 (comment)

Changes

Verification

  • pnpm test (378 tests)
  • pnpm typecheck
  • pnpm build:chrome, pnpm build:firefox, pnpm build:edge
Open in Web Open in Cursor 

Summary by cubic

Fixes BulkFlyout so bodySx styles apply to the scrollable body container, keeping the shell’s flex layout intact and matching the documented prop contract.

  • Bug Fixes
    • Moved bodySx merge from the shell Box to the body Box (rgp-bulk-flyout-body); shell keeps FLYOUT_SHELL_SX and dimensions only.
    • Added a regression test to confirm bodySx affects the body (e.g., display: grid) while the shell remains display: flex.

Written for commit 3fefb6f. Summary will update on new commits.

Review in cubic

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor auto review

No actionable issues found on changed lines.

No actionable issues found.

Generated automatically when this PR was submitted using Cursor CLI with --model auto.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@fathiraz fathiraz merged commit 6d7f7d4 into feat/bulk-actions-flyouts Jun 1, 2026
4 checks passed
@fathiraz fathiraz deleted the cursor/fix-bulk-flyout-bodysx-015f branch June 1, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants