fix(ui): apply BulkFlyout bodySx to body container#43
Merged
fathiraz merged 1 commit intoJun 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
bodySxfrom the flyout shellBoxto the scrollable bodyBox(rgp-bulk-flyout-body), matching the documented prop contract.Addresses review on #38 (comment)
Changes
src/ui/bulk-flyout.tsx: shell keepsFLYOUT_SHELL_SX+ dimensions only; body mergesbodySxafter base padding/scroll stylessrc/ui/__tests__/bulk-flyout.test.tsx: regression test assertsbodySxaffects body display, not shell flex layoutVerification
pnpm test(378 tests)pnpm typecheckpnpm build:chrome,pnpm build:firefox,pnpm build:edgeSummary by cubic
Fixes
BulkFlyoutsobodySxstyles apply to the scrollable body container, keeping the shell’s flex layout intact and matching the documented prop contract.bodySxmerge from the shellBoxto the bodyBox(rgp-bulk-flyout-body); shell keepsFLYOUT_SHELL_SXand dimensions only.bodySxaffects the body (e.g.,display: grid) while the shell remainsdisplay: flex.Written for commit 3fefb6f. Summary will update on new commits.