fix(queue-store): clear phase hints on auto-dismiss#42
Merged
fathiraz merged 1 commit intoJun 1, 2026
Conversation
Auto-dismiss timer removed processes but left phaseHintsMap entries, so reusing the same processId could show stale Undo/Retry. Centralize removal in removeProcess() and call it from scheduleDismiss.
There was a problem hiding this comment.
Cursor auto review
No actionable issues found on changed lines.
No actionable issues found. The removeProcess helper correctly centralizes timer, phaseHintsMap, and process cleanup for both manual and auto-dismiss paths, and the regression test covers the stale-hint scenario described in the PR.
Generated automatically when this PR was submitted using Cursor CLI with --model auto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes review feedback on #38 (discussion_r3332138647).
Problem
scheduleDismissremoved entries fromprocessesbut notphaseHintsMap. ManualqueueStore.dismiss()already cleared hints; auto-dismiss did not. Reusing the sameprocessIdcould surface stale Undo/Retry from a prior run.Fix
removeProcess()to clear dismiss timer (when applicable),phaseHintsMap, and the process entry.queueStore.dismiss()and from the auto-dismiss timer callback.Verification
All passed (378 tests).
Summary by cubic
Fixes a leak where auto-dismiss left phase hints behind, causing stale Undo/Retry when reusing a
processId. Centralizes process removal to clear timers, hints, and entries for consistent behavior.removeProcess()to clear dismiss timer,phaseHintsMap, and the process entry.queueStore.dismiss()and the auto-dismiss path inscheduleDismiss().Written for commit 8eed2ac. Summary will update on new commits.