fix(bulk-edit): await bulkUpdate dispatch before closing flyout

[fathiraz]

Summary

Addresses PR #38 review: the edit-fields flyout no longer pins Recent or closes after a failed bulkUpdate dispatch.

Changes

• Background: bulkUpdate returns { ok: true } immediately after accepting work, or { ok: false, reason: 'concurrent' } when the bulk slot is full. Long-running queue work runs in runBulkUpdate without blocking the message reply.
• Flyout: submitBulkFieldUpdate awaits dispatch, checks the queue preflight (getActiveCount() >= 3), and shows a warning Flash on failure. Success path only then calls onAppliedField and onClose.
• Tests: Dispatch unit tests for helpers and handler registration.

Verification

pnpm test && pnpm typecheck && pnpm build:chrome && pnpm build:firefox && pnpm build:edge

All passed locally.

  

---

Summary by cubic

Stops the bulk edit flyout from closing when a bulk update can’t start. The flyout now waits for the bulkUpdate dispatch and shows a warning if the queue is full or messaging fails.

• Bug Fixes

  • Apply waits for bulkUpdate to accept; on reject, shows a warning Flash and keeps the flyout open.
  • Preflight check blocks when 3 bulk processes are active (queueStore.getActiveCount()); disables Apply while sending to avoid duplicates.

• Refactors

  • bulkUpdate now returns an immediate dispatch result ({ ok: true } | { ok: false, reason: 'concurrent' }) and runs work in runBulkUpdate with acquire/release.
  • Updated message schema to return BulkUpdateDispatchResult; added tests for dispatch behavior and flyout submission.

^{Written for commit 8f89fbd. Summary will update on new commits.}

[github-actions]

Cursor auto review

No actionable issues found on changed lines.

No actionable issues found.

Generated automatically when this PR was submitted using Cursor CLI with --model auto.

[cubic-dev-ai]

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/background/bulk-update.ts">

<violation number="1" location="src/background/bulk-update.ts:57">
P1: Don’t broadcast `Done!` from the error path; it hides bulk-update failures as successes.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: Don’t broadcast Done! from the error path; it hides bulk-update failures as successes.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/background/bulk-update.ts, line 57:

<comment>Don’t broadcast `Done!` from the error path; it hides bulk-update failures as successes.</comment>

<file context>
@@ -24,265 +25,291 @@ import { broadcastQueue } from '@/background/rest-helpers'
-    if (isBulkFull()) {
-      console.warn('[rgp:bg] max concurrent bulk updates reached, rejecting')
+  try {
+    await broadcastQueue(
+      {
+        total: data.itemIds.length,
</file context>