Skip to content

fix(bulk): route Mark unlock to bulkUnlock#40

Merged
fathiraz merged 1 commit into
feat/bulk-actions-flyoutsfrom
cursor/fix-bulk-unlock-mark-b55b
Jun 1, 2026
Merged

fix(bulk): route Mark unlock to bulkUnlock#40
fathiraz merged 1 commit into
feat/bulk-actions-flyoutsfrom
cursor/fix-bulk-unlock-mark-b55b

Conversation

@fathiraz
Copy link
Copy Markdown
Owner

@fathiraz fathiraz commented Jun 1, 2026

Fixes #38 (comment)

The Mark flyout Unlock conversations row emitted verb: 'unlock', but handleMarkVerb called bulkLock, so GitHub received lockLockable instead of unlocking.

Changes

  • Add UNLOCK_ISSUE (unlockLockable) in graphql-mutations.ts
  • Add bulkUnlock protocol, schema, and background queue handler (mirrors bulkUnpin)
  • Route handleMarkVerb('unlock') to sendMessage('bulkUnlock', …)

bulk-mark-flyout.tsx row building is unchanged; existing flyout tests still pass.

Verification

pnpm install
pnpm test
pnpm typecheck
pnpm build:chrome && pnpm build:firefox && pnpm build:edge

377 tests passed locally.

Open in Web Open in Cursor 

Summary by cubic

Fixes the Mark flyout “Unlock conversations” bulk action so it actually unlocks selected issues instead of locking them. Adds bulkUnlock handling and the unlockLockable mutation to support bulk unlock.

  • Bug Fixes
    • Added UNLOCK_ISSUE (unlockLockable) in graphql-mutations.ts.
    • Implemented bulkUnlock protocol, schema, and background queue handler.
    • Routed Mark flyout verb 'unlock' to sendMessage('bulkUnlock', …).

Written for commit 1bd4539. Summary will update on new commits.

Review in cubic

Unlock conversations in the Mark flyout called bulkLock, which runs
lockLockable. Add UNLOCK_ISSUE, bulkUnlock message/schema, and a
background handler; wire handleMarkVerb unlock to bulkUnlock.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor auto review

No actionable issues found on changed lines.

No actionable issues found.

Generated automatically when this PR was submitted using Cursor CLI with --model auto.

@fathiraz fathiraz merged commit ccc5d98 into feat/bulk-actions-flyouts Jun 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants