fix(bulk): route Mark unlock to bulkUnlock#40
Merged
fathiraz merged 1 commit intoJun 1, 2026
Conversation
Unlock conversations in the Mark flyout called bulkLock, which runs lockLockable. Add UNLOCK_ISSUE, bulkUnlock message/schema, and a background handler; wire handleMarkVerb unlock to bulkUnlock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38 (comment)
The Mark flyout Unlock conversations row emitted
verb: 'unlock', buthandleMarkVerbcalledbulkLock, so GitHub receivedlockLockableinstead of unlocking.Changes
UNLOCK_ISSUE(unlockLockable) ingraphql-mutations.tsbulkUnlockprotocol, schema, and background queue handler (mirrorsbulkUnpin)handleMarkVerb('unlock')tosendMessage('bulkUnlock', …)bulk-mark-flyout.tsxrow building is unchanged; existing flyout tests still pass.Verification
377 tests passed locally.
Summary by cubic
Fixes the Mark flyout “Unlock conversations” bulk action so it actually unlocks selected issues instead of locking them. Adds
bulkUnlockhandling and theunlockLockablemutation to support bulk unlock.UNLOCK_ISSUE(unlockLockable) ingraphql-mutations.ts.bulkUnlockprotocol, schema, and background queue handler.'unlock'tosendMessage('bulkUnlock', …).Written for commit 1bd4539. Summary will update on new commits.