-
Notifications
You must be signed in to change notification settings - Fork 492
feat: add cmd+z undo support for deleting notes #3304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
6
commits into
main
Choose a base branch
from
devin/1769067354-undo-operations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds undo functionality for note deletion. When a user deletes a note, they can press Cmd+Z (Mac) / Ctrl+Z (Windows/Linux) or click the "Undo" button in a toast notification to restore it within 5 seconds.
How it works:
Files changed:
store/zustand/undo-delete.ts- New Zustand store tracking pending deletions +getPendingDeleteSessionIds()helperhooks/useUndoDelete.ts- Hook that registers the mod+z hotkeycomponents/undo-delete-toast/index.tsx- Toast UI with undo buttonstore/tinybase/store/deleteSession.ts- ExtracteddeleteSessionDatahelperstore/tinybase/persister/session/persister.ts- Modified cleanup to respect pending deletesdelete.tsx- Updated to use checkpoint-based deletionUpdates since last revision
keepIdsto prevent premature directory deletionkeyprop to AnimatePresence child (required for motion/react to properly track mount/unmount lifecycle)checkpoints.clear()after undo to clean up checkpoint historyReview & Testing Checklist for Human
Recommended test plan:
Notes
Known limitation: If undo is triggered after 5 seconds, the session data cannot be restored (toast is already gone). The audio file is permanently deleted at the 5-second mark.
Not tested locally: Due to Rust toolchain environment issues, local app testing was not possible. TypeScript typecheck passes and CI should verify the build.
Requested by @ComputelessComputer
Link to Devin run: https://app.devin.ai/sessions/364a0344939c4210be93395293bb208e