fix(persister): always load data on app start regardless of flag #3270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the data loss issue reported in #3269 where notes disappear after updates. Root cause: 1. The local persister was missing startAutoSave(), so changes were never persisted back to SQLite after the initial load. 2. The LocalPersisterLoaded flag prevented persister.load() from being called on subsequent app launches, even after updates. Changes: - Always call persister.load() on app start to ensure data is loaded - Add startAutoSave() to persist changes back to SQLite - The LocalPersisterLoaded flag now only controls whether migrations run (to prevent running migrations multiple times across windows) Fixes #3269 Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
devin-ai-integration
bot
changed the title
ComputelessComputer
requested review from
yujonglee
and removed request for
ComputelessComputer
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the data loss issue reported in #3269 where notes disappear after app updates.
Root cause identified:
The
LocalPersisterLoadedflag preventedpersister.load()from being called on subsequent app launches, even after updates. This meant data stored in SQLite wasn't being loaded into memory.Changes:
persister.load()on app start regardless of the flagLocalPersisterLoadedflag now only controls whether migrations run (to prevent running migrations multiple times across windows)Updates since last revision
Simplified the fix per user request - removed
startAutoSave()and just moved theload()call outside the conditional block.Review & Testing Checklist for Human
Recommended test plan:
Notes
Link to Devin run: https://app.devin.ai/sessions/cf8771b763104074ac9af90acd60029c
Requested by: @ComputelessComputer