fix: add explicit FS deletion in deleteSessionCascade #3218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on orphan cleanup to eventually delete session folders, explicitly delete the session folder after removing from TinyBase. This fixes the root cause of orphan accumulation by making deletion explicit rather than relying on eventual cleanup. Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes session deletion to explicitly delete the session folder from the filesystem instead of relying on orphan cleanup to eventually remove it.
Key changes:
fsSyncCommands.deleteSessionFolder(sessionId)call after TinyBase deletionaudioDeletecall (folder deletion should handle this)Context: Analysis of the FS↔TinyBase sync architecture revealed that orphan accumulation was caused by relying on eventual cleanup rather than explicit deletion. This fix addresses the root cause.
Review & Testing Checklist for Human
deleteSessionFolderdeletes audio files - TheaudioDeletecall was removed; confirm the folder deletion handles audio files properly (checkplugins/fs-sync/src/session.rs)deleteSessionFolderfails after TinyBase deletion succeeds, the system will be in an inconsistent state (TinyBase says deleted, FS still has files)Notes