Conversation
❌ Deploy Preview for hyprnote-storybook failed.
|
❌ Deploy Preview for hyprnote failed.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Stable build uses staging icons due to base config change
- Added bundle.icon and bundle.macOS.files overrides in tauri.conf.stable.json to point to stable icons and Assets.car instead of inheriting staging paths from base config.
Or push these changes by commenting:
@cursor push 28883d26d5
Preview (28883d26d5)
diff --git a/apps/desktop/src-tauri/tauri.conf.stable.json b/apps/desktop/src-tauri/tauri.conf.stable.json
--- a/apps/desktop/src-tauri/tauri.conf.stable.json
+++ b/apps/desktop/src-tauri/tauri.conf.stable.json
@@ -13,5 +13,19 @@
"https://desktop2.hyprnote.com/update/{{target}}-{{arch}}/{{current_version}}?channel=stable"
]
}
+ },
+ "bundle": {
+ "icon": [
+ "icons/stable/32x32.png",
+ "icons/stable/128x128.png",
+ "icons/stable/128x128@2x.png",
+ "icons/stable/icon.icns",
+ "icons/stable/icon.ico"
+ ],
+ "macOS": {
+ "files": {
+ "Resources/Assets.car": "resources/stable/Assets.car"
+ }
+ }
}
}This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
| "icons/staging/128x128.png", | ||
| "icons/staging/128x128@2x.png", | ||
| "icons/staging/icon.icns", | ||
| "icons/staging/icon.ico" |
There was a problem hiding this comment.
Stable build uses staging icons due to base config change
High Severity
The base tauri.conf.json icon paths were changed from icons/stable/* to icons/staging/*, and the files entry now points to resources/staging/Assets.car. Since tauri.conf.stable.json does not override bundle.icon or bundle.macOS.files, the stable production build will inherit these staging icon paths from the base config, shipping with the wrong icons.
Additional Locations (1)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The base tauri.conf.json had staging icon and Assets.car paths, which the stable build inherits since tauri.conf.stable.json doesn't override bundle.icon or bundle.macOS.files. Made-with: Cursor
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |



icon with tauri liquid icon package that reuse the .icon files for each macos themes: light/dark/glass/tinted
changed icon in menu bar. Return the logic of active state when recording + added image for available update
changed dmg backgrounds
changed some icons inside the desktop folder (not sure what they're doing tbh)
Note
Medium Risk
Mostly packaging/asset changes, but adds new tray-icon state and an async animation task driven by lifecycle/update events, which could affect tray stability and resource usage across platforms.
Overview
Updates the desktop app’s branding assets: replaces
public/assets/logo.svg, adds new.iconsources and Android adaptive icon resources, and sets macOSCFBundleIconName.Adjusts Tauri bundling to ship the new asset catalogs (
Resources/Assets.car) and switches the default bundle icon set to staging; nightly/staging configs now include theAssets.carmapping.Enhances the tray plugin to reflect runtime state: lifecycle events now toggle a recording animated tray icon, and updater events toggle an update available tray icon via new
set_recording/set_update_availableAPIs (addsrand+tokio::time).Includes a small TypeScript typing workaround in
jinjaLanguage(variablescast) and addstauri-liquid-iconto dev dependencies.Written by Cursor Bugbot for commit 3f90438. This will update automatically on new commits. Configure here.