fix: apply cargo clippy fixes#4649
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Conversation
- Remove unused import (tauri::Manager) in desktop app - Fix clippy warnings across analytics, tiptap, fs-db, and listener crates - Add missing Safety docs to unsafe functions in notification-macos - Exclude plugins/cli2 from Cargo workspace (missing Cargo.toml) Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies
cargo clippy --fixauto-fixes and one manual fix across the workspace:use tauri::Managerin desktop app&distinct_id.to_string()→distinct_idin posthog analyticsif/if letblocks into Rust let-chains intiptap,fs-db(2 migration files + version parser), andlistenergroup_by_session_id(2 occurrences in fs-db migrations)# Safetydoc: Added safety documentation to unsafe extern "C" functions innotification-macosmacroplugins/cli2toCargo.tomlexclude list (directory exists with onlynode_modules, noCargo.toml, breaking theplugins/*glob)Review & Testing Checklist for Human
plugins/cli2exclusion inCargo.tomlis correct — this was needed because the directory has noCargo.tomlbut was picked up by theplugins/*workspace glob. Confirmcli2is indeed a JS-only plugin that shouldn't be a Cargo workspace member.crates/tiptap/src/from_ast.rsandplugins/fs-db/src/version/macro.rs) — they were auto-applied bycargo clippy --fixand the indentation looks slightly unusual, though the logic should be semantically identical to the original nestedifblocks.cargo clippyon macOS to verify the excluded macOS-only crates (notch,am2,tcc,control-tauri) also pass cleanly — these couldn't be checked on Linux due to missingswift_rs/objc2dependencies.Notes
tools,control-tauri,notch,am2,tcc) could not be compiled on Linux due to macOS-only dependencies (swift_rs,objc2_app_kit,libspa/pipewire). These were excluded from the clippy run but are not modified in this PR.Link to Devin session: https://app.devin.ai/sessions/b7c8ae79466b496b9fe23b1dc0b2a6e2