Skip to content

Comments

vivado/vitis support sample broadcasting merge ops#1426

Open
calad0i wants to merge 1 commit intofastmachinelearning:mainfrom
calad0i:bcasting_add
Open

vivado/vitis support sample broadcasting merge ops#1426
calad0i wants to merge 1 commit intofastmachinelearning:mainfrom
calad0i:bcasting_add

Conversation

@calad0i
Copy link
Contributor

@calad0i calad0i commented Jan 26, 2026

Description

Allow add/subtract/mul/avg/... between tensors of shape (a, b, c) and (1, c) or (c,) or (1, b, c) (must match the last dimensions) in vivado/vitis backends. Illegal operations still fail silently like what they do now.

Type of change

  • New feature (non-breaking change which adds functionality)

Tests

Checklist

  • all

@bo3z bo3z added enhancement please test Trigger testing by creating local PR branch labels Jan 30, 2026
@bo3z bo3z added this to the v1.3.0 milestone Jan 30, 2026
@JanFSchulte
Copy link
Contributor

Looks like there are issues with the streaming implementation of merge, all the test failures are caused by compiler errors like

firmware/nnet_utils/nnet_merge_stream.h:15:35: error: ‘n_elem’ is not a member of ‘config3’
   15 |     for (int i = 0; i < CONFIG_T::n_elem / input1_T::size; i++) {

@calad0i
Copy link
Contributor Author

calad0i commented Feb 17, 2026

Streaming supported is not added, so it is still broken as what it was.

@JanFSchulte
Copy link
Contributor

JanFSchulte commented Feb 24, 2026

But your change introduces compilation errors because it removes n_elem from the config and replaces it with n_elem1 and n_elem2. So the streaming application needs to get a dedicated configuration if you don't want to implement this feature for it.

Or if it is indeed broken, streaming needs to be excluded from the affected tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement please test Trigger testing by creating local PR branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants