vivado/vitis support sample broadcasting merge ops#1426
Open
calad0i wants to merge 1 commit intofastmachinelearning:mainfrom
Open
vivado/vitis support sample broadcasting merge ops#1426calad0i wants to merge 1 commit intofastmachinelearning:mainfrom
calad0i wants to merge 1 commit intofastmachinelearning:mainfrom
Conversation
Contributor
|
Looks like there are issues with the streaming implementation of merge, all the test failures are caused by compiler errors like |
Contributor
Author
|
Streaming supported is not added, so it is still broken as what it was. |
Contributor
|
But your change introduces compilation errors because it removes Or if it is indeed broken, streaming needs to be excluded from the affected tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow add/subtract/mul/avg/... between tensors of shape
(a, b, c)and(1, c)or(c,)or(1, b, c)(must match the last dimensions) in vivado/vitis backends. Illegal operations still fail silently like what they do now.Type of change
Tests
Checklist