-
Notifications
You must be signed in to change notification settings - Fork 507
Integration of PQuantML with hls4ml #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
What's the plan for installing PQuant together with hls4ml? In principle, we should have I expect the pytests to fail currently because of this. We are preparing a dedicated testing container with keras 3 that should be able to be used for this going forward, but that would then need the proper installation instructions for pquant to work. Also, would be nice to have the documentation update included in this PR ;) |
I have now included it.
This is a known issue for the PQuantML team and they are trying to solve it. As far as I have understood, the problem is due to pip trying to install the wrong version of tensorflow, and the only solution at the moment is "manually" installing it with conda.
Added :) |
7a04955 to
a8b3c1f
Compare
Description
This PR introduces the possibility of directly parsing PQuantML layers into hls4ml, both using the PyTorch and Keras V3 frontend. It uses HGQ2 conventions and relies on the bit_exact optimization pass to ensure correct precision is enforced and bit exactness.
Type of change
Tests
Tests are present both for PyTorch and Keras V3 frontend:
test_pquant_pytoch.pyandtest_pquant_keras.py.Checklist
pre-commiton the files I edited or added.